Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PackageVersion for PowerShell Preview 7.3.0.101 #99813

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Fix PackageVersion for PowerShell Preview 7.3.0.101 #99813

merged 2 commits into from
Apr 28, 2023

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Mar 17, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service
Copy link
Contributor

Hello @mdanish-kh,

During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest.
Please adjust the manifest accordingly.

Template: msftbot/validationError/manifest/installerValidation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 17, 2023
@mdanish-kh mdanish-kh marked this pull request as draft March 17, 2023 22:08
@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Installer-Validation-Error Manifest installer validation failed Needs-Author-Feedback This needs a response from the author. labels Mar 17, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @mdanish-kh,

During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest.
Please adjust the manifest accordingly.

Template: msftbot/validationError/manifest/installerValidation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 17, 2023
@mdanish-kh mdanish-kh closed this Mar 21, 2023
@mdanish-kh mdanish-kh reopened this Mar 23, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Mar 23, 2023
@mdanish-kh mdanish-kh marked this pull request as ready for review March 23, 2023 23:40
@wingetbot wingetbot added the Manifest-Installer-Validation-Error Manifest installer validation failed label Mar 23, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @mdanish-kh,

During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest.
Please adjust the manifest accordingly.

Template: msftbot/validationError/manifest/installerValidation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Mar 23, 2023
anamnavi
anamnavi previously approved these changes Mar 24, 2023
Copy link
Contributor

@anamnavi anamnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephengillie stephengillie self-assigned this Mar 24, 2023
@stephengillie
Copy link
Collaborator

stephengillie commented Mar 24, 2023

x86 Manual Validation failed with:

@Fatalerror.0xC0000005 atSystem.Management.Automation.Security.SystemPolicy+WldpNativeMethods.WldpCanExecuteFile(System.Guid,WLDP_EXECUTION_EVALUATION_OPTIONS,IntPtr,System.String,WLDP_EXECUTION_POLICYByRef) atSystem.Management.Automation.Security.SystemPolicy.GetFilePolicyEnforcement(System.String,System.IO.FileStream) atSystem.Management.Automation.ExternalScriptInfo.ReadScriptContents() atSystem.Management.Automation.ExternalScriptInfo.get_ScriptBlock() atMicrosoft.PowerShell.Commands.ModuleCmdletBase.LoadModuleManifestData(System.Management.Automation.ExternalScriptInfo,System.String[],ManifestProcessingFlags,BooleanByRef) atMicrosoft.PowerShell.Commands.ModuleCmdletBase.LoadModuleManifestData(System.Management.Automation.ExternalScriptInfo,ManifestProcessingFlags,System.Collections.HashtableByRef,System.Collections.HashtableByRef,BooleanByRef) atMicrosoft.PowerShell.Commands.ModuleCmdletBase.LoadModule(System.Management.Automation.PSModuleInfo,System.String,System.String,System.String,System.Management.Automation.SessionState,System.Object,ImportModuleOptionsByRef,ManifestProcessingFlags,BooleanByRef,BooleanByRef) atMicrosoft.PowerShell.Commands.ModuleCmdletBase.LoadUsingExtensions(System.Management.Automation.PSModuleInfo,System.String,System.String,System.String,System.String,System.String,System.Management.Automation.SessionState,ImportModuleOptions,ManifestProcessingFlags,BooleanByRef,BooleanByRef) atMicrosoft.PowerShell.Commands.ModuleCmdletBase.LoadUsingModulePath(System.Management.Automation.PSModuleInfo,System.Collections.Generic.IEnumerable`1<System.String>,System.String,System.Management.Automation.SessionState,ImportModuleOptions,ManifestProcessingFlags,System.Management.Automation.PSModuleInfoByRef) atMicrosoft.PowerShell.Commands.ImportModuleCommand.ImportModule_LocallyViaName(ImportModuleOptions,System.String) atMicrosoft.PowerShell.Commands.ImportModuleCommand.ImportModule_LocallyViaName_WithTelemetry(ImportModuleOptions,System.String) atMicrosoft.PowerShell.Commands.ImportModuleCommand.ProcessRecord() atSystem.Management.Automation.Cmdlet.DoProcessRecord() atSystem.Management.Automation.CommandProcessor.ProcessRecord() atSystem.Management.Automation.CommandProcessorBase.DoExecute() atSystem.Management.Automation.Internal.PipelineProcessor.Inject(System.Object,Boolean) atSystem.Management.Automation.Internal.PipelineProcessor.SynchronousExecuteEnumerate(System.Object) atSystem.Management.Automation.Runspaces.LocalPipeline.InvokeHelper() atSystem.Management.Automation.Runspaces.LocalPipeline.InvokeThreadProc() atSystem.Management.Automation.Runspaces.LocalPipeline.InvokeThreadProcImpersonate() atSystem.Management.Automation.Runspaces.PipelineThread.WorkerProc() atSystem.Threading.Thread+StartHelper.Callback(System.Object) atSystem.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext,System.Threading.ContextCallback,System.Object) atSystem.Threading.Thread.StartCallback() ,

@stephengillie stephengillie removed their assignment Mar 24, 2023
@mdanish-kh
Copy link
Contributor Author

mdanish-kh commented Mar 25, 2023

x86 Manual Validation failed with:

I just changed the PackageVersion for an already merged manifest👀 Not sure why it's failing now...

The installer is the same with same hash that previously passed the pipelines and got merged into the repo in PR #95187

- Architecture: x86
InstallerType: wix
InstallerUrl: https://github.com/PowerShell/PowerShell/releases/download/v7.3.0-rc.1/PowerShell-7.3.0-rc.1-win-x86.msi
InstallerSha256: F23DF935F22513443606B261E0EE696F3AC22A6CE77F1FF6EDE788F67E08BC60

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Mar 25, 2023
@mdanish-kh
Copy link
Contributor Author

@stephengillie @anamnavi - Should I remove the x86 installer from the PR and let this get merged? We can add the x86 in a separate PR. This would unblock a number of users currently experiencing infinite upgrade problems with this package since the versioning isn't consistent across all manifests of PowerShell Preview

@stephengillie
Copy link
Collaborator

@stephengillie @anamnavi - Should I remove the x86 installer from the PR and let this get merged? We can add the x86 in a separate PR. This would unblock a number of users currently experiencing infinite upgrade problems with this package since the versioning isn't consistent across all manifests of PowerShell Preview

@mdanish-kh Sorry to miss this. Yes, we probably should remove the x86 for now. This appears to be a known issue with x86 Microsoft.PowerShell version 7.3.0, and the fix appears to be using x86 version 7.2.7 and modifying the Environment Variable POWERSHELL_UPDATECHECK=Off to disable the update notice.

@mdanish-kh mdanish-kh dismissed stale reviews from ItzLevvie and anamnavi via 996b697 April 28, 2023 16:08
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Manifest-Installer-Validation-Error Manifest installer validation failed label Apr 28, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Apr 28, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdanish-kh
Copy link
Contributor Author

@mdanish-kh Sorry to miss this. Yes, we probably should remove the x86 for now. This appears to be a known issue with x86 Microsoft.PowerShell version 7.3.0, and the fix appears to be using x86 version 7.2.7 and modifying the Environment Variable POWERSHELL_UPDATECHECK=Off to disable the update notice.

No worries :) I've updated the other two PRs as well

@wingetbot wingetbot added the Manifest-Installer-Validation-Error Manifest installer validation failed label Apr 28, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @mdanish-kh,

During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest.
Please adjust the manifest accordingly.

Template: msftbot/validationError/manifest/installerValidation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 28, 2023
@anamnavi
Copy link
Contributor

Thanks for removing @mdanish-kh . I'll check with the team if we have another x86 installer where this is fixed, and open a separate PR to add it back. For now makes sense to remove it and get this in. Thanks!

@stephengillie stephengillie added Validation-Completed Validation passed and removed Needs-Author-Feedback This needs a response from the author. Manifest-Installer-Validation-Error Manifest installer validation failed labels Apr 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 28, 2023 19:39
@microsoft-github-policy-service
Copy link
Contributor

mdanish-kh,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit d0e70d8 into microsoft:master Apr 28, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 28, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

1 similar comment
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants