-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PackageVersion for PowerShell Preview 7.3.0.101 #99813
Fix PackageVersion for PowerShell Preview 7.3.0.101 #99813
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @mdanish-kh, During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest. Template: msftbot/validationError/manifest/installerValidation |
Hello @mdanish-kh, During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest. Template: msftbot/validationError/manifest/installerValidation |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @mdanish-kh, During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest. Template: msftbot/validationError/manifest/installerValidation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
x86 Manual Validation failed with:
|
I just changed the PackageVersion for an already merged manifest👀 Not sure why it's failing now... The installer is the same with same hash that previously passed the pipelines and got merged into the repo in PR #95187 Lines 22 to 25 in 59ff409
|
@stephengillie @anamnavi - Should I remove the x86 installer from the PR and let this get merged? We can add the x86 in a separate PR. This would unblock a number of users currently experiencing infinite upgrade problems with this package since the versioning isn't consistent across all manifests of PowerShell Preview |
@mdanish-kh Sorry to miss this. Yes, we probably should remove the x86 for now. This appears to be a known issue with |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
No worries :) I've updated the other two PRs as well |
Hello @mdanish-kh, During validation, the MSIX package was evaluated. There were either inconsistencies or values not present in the manifest. Template: msftbot/validationError/manifest/installerValidation |
Thanks for removing @mdanish-kh . I'll check with the team if we have another x86 installer where this is fixed, and open a separate PR to add it back. For now makes sense to remove it and get this in. Thanks! |
mdanish-kh, The check-in policies require a moderator to approve PRs from the community. Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission. Template: msftbot/requiresApproval/moderator |
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
1 similar comment
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow