Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: rhysd.actionlint version 1.6.23 #94753

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Jan 27, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 27, 2023
@ghost
Copy link

ghost commented Jan 27, 2023

Hello @sitiom,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.4 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 27, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 27, 2023

Manifest 1.4

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 27, 2023
Dee334
Dee334 previously approved these changes Jan 27, 2023
@ghost
Copy link

ghost commented Jan 27, 2023

Hello @sitiom,

This package appears to require dependencies in order to install successfully.

This PR is blocked until support for dependencies is implemented in:

Template: msftbot/blockingIssue/dependencySupport

@ghost ghost added the Blocking-Issue Manifest validation is blocked by a known issue. label Jan 27, 2023
@sitiom sitiom force-pushed the rhysd.actionlint-1.6.23-1B7AEE4D981E62 branch from 73ce42c to b953885 Compare January 31, 2023 01:09
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Manifest-Validation-Error Manifest validation failed Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 31, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jan 31, 2023
@ghost ghost assigned stephengillie and zachcarp Jan 31, 2023
@Trenly
Copy link
Contributor

Trenly commented Jan 31, 2023

@msftbot dependencies

@ghost ghost added Needs-Author-Feedback This needs a response from the author. Blocking-Issue Manifest validation is blocked by a known issue. labels Jan 31, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 31, 2023

Dependencies?

@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Jan 31, 2023
@sitiom
Copy link
Contributor Author

sitiom commented Jan 31, 2023

This package has no dependencies and runs successfully as tested in a Sandbox.

@sitiom sitiom force-pushed the rhysd.actionlint-1.6.23-1B7AEE4D981E62 branch from b953885 to edf1430 Compare January 31, 2023 08:49
@ghost ghost removed Validation-Executable-Error Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jan 31, 2023
@ghost ghost assigned stephengillie and zachcarp Jan 31, 2023
@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Feb 1, 2023
@stephengillie stephengillie self-assigned this Feb 1, 2023
@stephengillie stephengillie added the Validation-Completed Validation passed label Feb 1, 2023
@stephengillie stephengillie removed the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Feb 1, 2023
@stephengillie stephengillie merged commit c712d86 into microsoft:master Feb 1, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@sitiom sitiom deleted the rhysd.actionlint-1.6.23-1B7AEE4D981E62 branch February 2, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants