Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zip][EXE][WiX] New package: dotPDN.PaintDotNET version 4.3.12 #90341

Conversation

SpecterShell
Copy link
Contributor

@SpecterShell SpecterShell commented Dec 2, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.2 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@SpecterShell SpecterShell changed the title New package: dotPDN.PaintDotNET version 4.3.12 [Zip][EXE][WiX] New package: dotPDN.PaintDotNET version 4.3.12 Dec 2, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hello @SpecterShell,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.2 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Dec 2, 2022
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is the same as #88065, although there is a bit more metadata here around the upgrade code and install location switches that I can pull into the other PR

Comment on lines +32 to +34
AppsAndFeaturesEntries:
- UpgradeCode: '{04A40F40-A207-4B48-AED7-6AA532E43275}'
InstallerType: wix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this cause issues with the portable entry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. You can add this to per-installer entries.

@ghost ghost assigned SpecterShell Dec 2, 2022
@ghost
Copy link

ghost commented Dec 2, 2022

Hello @SpecterShell,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

Trenly added a commit to Trenly/winget-pkgs that referenced this pull request Dec 2, 2022
@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 3, 2022
stephengillie pushed a commit that referenced this pull request Jan 31, 2023
…88065)

* [Zip][Installer/Portable] New Package: dotPDNLLC.paintdotnet 4.3.12

* Update command aliases

* Merge newer metadata from #90341

* Oop - 5.0.1 is required

* Update Hashes
@SpecterShell SpecterShell deleted the dotPDN.PaintDotNET-4.3.12-8A039227EF21D6 branch May 12, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants