Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Multi-line Field Exclude ending Newline #77631

Merged
3 commits merged into from
Jan 31, 2023
Merged

Make Multi-line Field Exclude ending Newline #77631

3 commits merged into from
Jan 31, 2023

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Sep 2, 2022 •
edited by ghost
Loading

null

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Sep 2, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 2, 2022
@ghost
Copy link

ghost commented Sep 2, 2022

Hello @Trenly,

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Sep 2, 2022
@Trenly
Copy link
Contributor Author

Trenly commented Sep 2, 2022

@denelon - Blocking Issue

2022-09-02 04:42:57.503 [CLI ] Caught std::exception: No mapping for the Unicode character exists in the target multi-byte code page.

microsoft/winget-cli#2057

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 2, 2022
@Trenly
Copy link
Contributor Author

Trenly commented Oct 18, 2022

@MSFTBot blocking-issue

@ghost ghost added Needs-Author-Feedback This needs a response from the author. Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Oct 18, 2022
@stephengillie
Copy link
Collaborator

Validation is blocked by

@stephengillie stephengillie self-assigned this Dec 22, 2022
@Trenly
Copy link
Contributor Author

Trenly commented Dec 22, 2022

Validation is blocked by

Tell me something I don’t know!

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 22, 2022
@stephengillie stephengillie removed their assignment Dec 22, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

There was an error handling pipeline event 9ab72a99-9414-4648-9071-d2c01191820f.

@ghost ghost removed Validation-Installation-Error Error installing application Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 31, 2023
@ghost ghost removed Internal-Error An unidentified error occurred in the validation pipeline Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 31, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 31, 2023
@ghost
Copy link

ghost commented Jan 31, 2023

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jan 31, 2023

Trenly,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 31, 2023
@ghost
Copy link

ghost commented Jan 31, 2023

Hello Trenly,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot wingetbot added the Validation-Merge-Conflict Package could not be tested due to merge conflict. label Jan 31, 2023
@ghost ghost removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jan 31, 2023
@ghost
Copy link

ghost commented Jan 31, 2023

Hello @Trenly,

The PR could not be validated because there is a merge conflict which adds bad characters to the manifest. Please address the merge conflict and resubmit.

Template: msftbot/mergeConflict

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 31, 2023
@ghost ghost removed Validation-Completed Validation passed Needs-Author-Feedback This needs a response from the author. labels Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 31, 2023
@ghost ghost merged commit ea6b312 into microsoft:master Jan 31, 2023
@ghost ghost removed the Validation-Merge-Conflict Package could not be tested due to merge conflict. label Jan 31, 2023
@Trenly Trenly deleted the 8ba2e3e745c745c6a8a1fe054bbd0d84 branch January 31, 2023 16:15
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImJoakim ImJoakim ImJoakim approved these changes

@jedieaston jedieaston jedieaston approved these changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees
No one assigned
Labels
Publish-Pipeline-Succeeded
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trenly @wingetbot @stephengillie @ItzLevvie @jedieaston @ImJoakim @zachcarp