Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Multi-line Field Exclude ending Newline #77619

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Make Multi-line Field Exclude ending Newline #77619

merged 2 commits into from
Feb 1, 2023

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Sep 2, 2022 •
edited by ghost
Loading

null

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Sep 2, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 2, 2022
@ghost
Copy link

ghost commented Sep 2, 2022

Hello @Trenly,

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Sep 2, 2022
@Trenly
Copy link
Contributor Author

Trenly commented Sep 2, 2022

@denelon - Blocking Issue

2022-09-02 04:42:57.503 [CLI ] Caught std::exception: No mapping for the Unicode character exists in the target multi-byte code page.

microsoft/winget-cli#2057

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 2, 2022
@denelon denelon added Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 2, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

There was an error handling pipeline event 0a536b75-5c1c-4597-a480-fb3f3ff8b706.

@ghost ghost removed Validation-Installation-Error Error installing application Blocking-Issue Manifest validation is blocked by a known issue. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 31, 2023
@ghost
Copy link

ghost commented Jan 31, 2023

Hello @Trenly,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 31, 2023
@ghost ghost assigned stephengillie and zachcarp Jan 31, 2023
@ghost ghost added the Retry-1 flag to indicate retried label Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 31, 2023
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 31, 2023
@ghost
Copy link

ghost commented Jan 31, 2023

Hello @Trenly,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 31, 2023
@ghost ghost assigned stephengillie and zachcarp Jan 31, 2023
@stephengillie
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie stephengillie removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 31, 2023
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 31, 2023
@stephengillie
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie stephengillie removed the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 31, 2023
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 31, 2023
@stephengillie
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie stephengillie added Validation-Completed Validation passed Moderator-Approved One of the Moderators has reviewed and approved this PR and removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. labels Feb 1, 2023
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Feb 1, 2023
@stephengillie stephengillie merged commit 7ad121c into microsoft:master Feb 1, 2023
@Trenly Trenly deleted the 1184a011a4cd49e9a551300b90cf171e branch February 1, 2023 21:12
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

@jedieaston jedieaston jedieaston approved these changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees

@zachcarp zachcarp

@stephengillie stephengillie

Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trenly @wingetbot @stephengillie @ItzLevvie @jedieaston @zachcarp @denelon