Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize DiegoFernandes.jsdesign 1.0.2 #73069

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Normalize DiegoFernandes.jsdesign 1.0.2 #73069

merged 3 commits into from
Feb 6, 2023

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Aug 27, 2022 •
edited by ghost
Loading

null

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

ItzLevvie
ItzLevvie previously approved these changes Aug 27, 2022
View reviewed changes
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 27, 2022
@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Aug 27, 2022
@ghost
Copy link

ghost commented Aug 27, 2022

Hello @Trenly,
I am sorry to report that the Sha256 Hash does not match the installer. This maybe caused by using a vanity URL rather than a URL directly to the binary.

Please check the HASH and submit again. Sorry for the inconvenience.

Template: msftbot/validationError/installers/hashMismatch

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 27, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Author-Feedback This needs a response from the author. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Aug 27, 2022
OfficialEsco
OfficialEsco previously approved these changes Aug 27, 2022
View reviewed changes
Copy link
Contributor

@OfficialEsco OfficialEsco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Enter a pull request number: #73069

Manifest validation succeeded.
Found 即时设计 [DiegoFernandes.jsdesign] Version 1.0.4
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
An unexpected error occurred while executing the command:
No mapping for the Unicode character exists in the target multi-byte code page.

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 27, 2022
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Aug 27, 2022
@ghost
Copy link

ghost commented Aug 27, 2022

Hello @Trenly,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 27, 2022
@Trenly
Copy link
Contributor Author

Trenly commented Aug 30, 2022

@denelon - Blocking Issue

microsoft/winget-cli#2057

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Aug 30, 2022
@denelon denelon added the Blocking-Issue Manifest validation is blocked by a known issue. label Aug 30, 2022
jedieaston
jedieaston previously approved these changes Oct 1, 2022
View reviewed changes
@ghost ghost removed Validation-Installation-Error Error installing application Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost assigned stephengillie and zachcarp Jan 31, 2023
@ghost
Copy link

ghost commented Jan 31, 2023

Hello @Trenly,

One or more of the installer URLs doesn't appear valid.

This may happen for sites with policies prohibiting distribution or use by third parties.

This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.

Template: msftbot/validationError/urls/domain

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 31, 2023
@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Domain

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Completed Validation passed label Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error An unidentified error occurred in the validation pipeline label Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Feb 6, 2023

Ping-pong @stephengillie

@stephengillie stephengillie removed Internal-Error An unidentified error occurred in the validation pipeline Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. labels Feb 6, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie stephengillie merged commit 1513f09 into microsoft:master Feb 6, 2023
@Trenly Trenly deleted the 6c08b00616034528b4079e440bbf0233 branch February 6, 2023 21:17
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

1 similar comment
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@stephengillie stephengillie mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

@jedieaston jedieaston jedieaston left review comments

@OfficialEsco OfficialEsco OfficialEsco left review comments

@ItzLevvie ItzLevvie ItzLevvie left review comments

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. Validation-Completed Validation passed Validation-Domain Waived-Validation-Domain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trenly @wingetbot @stephengillie @ItzLevvie @OfficialEsco @jedieaston @zachcarp @denelon