Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Diskuv.OCaml.1.0.0.0 #69112

Closed
wants to merge 4 commits into from
Closed

Conversation

jonahbeckford
Copy link
Contributor

@jonahbeckford jonahbeckford commented Aug 9, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 9, 2022
@ghost ghost assigned jonahbeckford Aug 9, 2022
@ghost
Copy link

ghost commented Aug 9, 2022

Hello @jonahbeckford,
The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Aug 9, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Aug 9, 2022
@ghost ghost assigned jonahbeckford Aug 9, 2022
@ghost
Copy link

ghost commented Aug 9, 2022

Hello @jonahbeckford,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 9, 2022
@ghost ghost assigned zachcarp and florelis Aug 9, 2022
ItzLevvie
ItzLevvie previously approved these changes Aug 9, 2022
@ItzLevvie
Copy link
Contributor

@wingetbot run

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 9, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Aug 9, 2022
@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Aug 13, 2022
@ghost ghost removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Aug 13, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Aug 13, 2022
@ghost
Copy link

ghost commented Aug 13, 2022

Hello @jonahbeckford,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 13, 2022
@jonahbeckford
Copy link
Contributor Author

Hmm ... it does work for me in the Windows Sandbox using winget:

>> # Rerun the installer; if you are prompted for security now you'll be able to click through it
>> winget install --manifest ..\SandboxTest\manifest
>>
HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer SmartScreenEnabled=Off
HKCU:\SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer SmartScreenEnabled=Off
Found Diskuv OCaml [Diskuv.OCaml] Version 1.0.0.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Successfully verified installer hash
Starting package install...
Successfully installed
PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs>

So am rerunning with updated .yaml to see if something I edited is making it pass for me locally.

It has things I don't like:

  1. It takes ~2 hours to complete. That won't reduce until OCaml (the programming language) stops requiring the installation path to be embedded in its binaries. And that won't change for ~1 year.
  2. winget does not install the dependencies Visual Studio Build Tools and Git. Nothing I place in Dependencies: seems to matter. It is not terrible since my installer will not install Visual Studio Build Tools and Git if they are already present and compatible, but I'm hoping to model these dependencies correctly.

And the wingetcreate is using ManifestVersion: 1.2.0 which is too new. I'll downgrade and resubmit.

@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Aug 13, 2022
@ghost ghost removed Manifest-Validation-Error Manifest validation failed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 13, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Aug 14, 2022
@ghost ghost assigned jonahbeckford Aug 14, 2022
@ghost
Copy link

ghost commented Aug 14, 2022

Hello @jonahbeckford,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 14, 2022
@ghost ghost assigned florelis and msftrubengu Aug 14, 2022
@jonahbeckford
Copy link
Contributor Author

This looks like a 2hr time limit since this succeeds in Windows Sandbox. I can withdraw this PR and resubmit when it is under 2hr if it is just the time limit blocking this.

(Some time can be shaved off if I didn't need to install Visual Studio Build Tools and Git when they are not already present.)

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Aug 14, 2022
@denelon
Copy link
Contributor

denelon commented Aug 15, 2022

@jonahbeckford the long install time is causing us to time out. The client does have an experimental feature for dependencies, but we would still need to install those for validation. We're looking into options to see if there is something we might be able to do for packages that take an exceptionally long time.

@jonahbeckford
Copy link
Contributor Author

No worries. Thanks for looking. I'll withdraw this PR and resubmit when the install time is shrunk. That will be a win for everyone concerned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants