Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: Plex.Plex version 1.55.0 [FP-D] #68237

Merged
1 commit merged into from
Sep 30, 2022
Merged

New version: Plex.Plex version 1.55.0 [FP-D] #68237

1 commit merged into from
Sep 30, 2022

Conversation

vedantmgoyal9
Copy link
Contributor

@vedantmgoyal9 vedantmgoyal9 commented Jul 31, 2022 •
edited
Loading

Result: Installation Successful

Manifest Add/Remove Programs
Name Plex Plex
Version 1.55.0 1.55.0
Publisher Plex, Inc. Plex, Inc.
ProductCode Plex

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 3320

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jul 31, 2022
@ghost
Copy link

ghost commented Jul 31, 2022

Hello @vedantmgoyal2009,
The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jul 31, 2022
ItzLevvie
ItzLevvie previously approved these changes Jul 31, 2022
View reviewed changes
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 31, 2022
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Aug 8, 2022
@ghost
Copy link

ghost commented Aug 8, 2022

Hello @vedantmgoyal2009,
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. labels Aug 9, 2022
@denelon denelon removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Aug 23, 2022
@vedantmgoyal9
Copy link
Contributor Author

@denelon please assign to an engineer...

@Madhusudhan-MSFT
Copy link
Contributor

@vedantmgoyal2009 - I investigated bit on this installer validation failure. On our local sandbox environment installation is failing with following exception per logs and I do see same exception with the validation pipeline logs.

2022-07-31 14:14:21.676 [CLI ] Completed installer selection.
2022-07-31 14:14:21.729 [CLI ] Caught std::exception: No mapping for the Unicode character exists in the target multi-byte code page.

not sure if this is related to resources file content. Will check with team for the additional understanding.

@florelis
Copy link
Member

Looks like a client bug triggered by the Installer URI.

Debugging I found that this is throwing while generating the download path for the installer here:
https://github.com/microsoft/winget-cli/blob/1a6ca17040a0577dceb25af3232649e4bd271b81/src/AppInstallerCLICore/Workflows/DownloadFlow.cpp#L72

At this point, from the installer URI https://download.cnki.net/cnkiexpress/%E5%85%A8%E7%90%83%E5%AD%A6%E6%9C%AF%E5%BF%AB%E6%8A%A5%20Setup%200.2.23.exe we have extracted the file name "全球学术快报%20Setup%200.2.23.exe", which seems to be causing that line to throw.

I haven't looked into why it's throwing, so I have no idea for a possible fix.

@florelis
Copy link
Member

Oh, there's already an issue in the client for this...
microsoft/winget-cli#2057

@Madhusudhan-MSFT Madhusudhan-MSFT added the Blocking-Issue Manifest validation is blocked by a known issue. label Aug 29, 2022
@vedantmgoyal9 vedantmgoyal9 marked this pull request as draft September 30, 2022 14:37
@vedantmgoyal9 vedantmgoyal9 marked this pull request as ready for review September 30, 2022 17:08
@vedantmgoyal9 vedantmgoyal9 changed the title New version: TTKN.CNKIExpress version 0.2.23 New version: Plex.Plex version 1.55.0 [FP-D] Sep 30, 2022
@vedantmgoyal-bot vedantmgoyal-bot bot force-pushed the TTKN.CNKIExpress-0.2.23-0EEE7D08A50A60 branch from 93a3e49 to 8b4a40b Compare September 30, 2022 17:08
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed Validation-Installation-Error Error installing application Blocking-Issue Manifest validation is blocked by a known issue. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Sep 30, 2022
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 30, 2022
@ghost
Copy link

ghost commented Sep 30, 2022

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Sep 30, 2022

vedantmgoyal2009,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 30, 2022
@ghost
Copy link

ghost commented Sep 30, 2022

Hello vedantmgoyal2009,
Validation has completed.

Template: msftbot/validationCompleted

@ghost ghost merged commit e23db8a into microsoft:master Sep 30, 2022
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@ItzLevvie ItzLevvie deleted the TTKN.CNKIExpress-0.2.23-0EEE7D08A50A60 branch June 18, 2023 16:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vedantmgoyal9 @wingetbot @Madhusudhan-MSFT @florelis @ItzLevvie @denelon @AmelBawa-msft