Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Anvil Studio 2020.12.03 #535

Merged
4 commits merged into from
Apr 14, 2021
Merged

Add Anvil Studio 2020.12.03 #535

4 commits merged into from
Apr 14, 2021

Conversation

chausner
Copy link
Contributor

@chausner chausner commented May 21, 2020 •
edited by ghost
Loading

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 21, 2020
@ghost ghost assigned denelon May 21, 2020
@ghost
Copy link

ghost commented May 21, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Installation-Error Error installing application label May 22, 2020
@ghost
Copy link

ghost commented May 22, 2020

chausner The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels May 22, 2020
@KevinLaMS
Copy link
Contributor

Installer failed with exit code 1000

@chausner
Copy link
Contributor Author

Installer failed with exit code 1000

Yes, this is to be expected. See also the comment I added in the manifest file. The installer in this case is wrapped in a WinRAR self-extracting archive. After extracting, RARSFX runs the installer and returns with the installer exit code + 1000. That means, if the installer succeeded (exit code 0), RARSFX will return exit code 1000.

We need a way to specify a success exit code in the manifest file, as not all applications on Windows adhere to 0 = success.

@ghost ghost removed the Needs: author feedback label May 22, 2020
@chausner chausner mentioned this pull request May 22, 2020
Closed
@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 24, 2020
@ghost ghost removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application labels Apr 3, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chausner chausner changed the title Add Anvil Studio 2020.04.03 Add Anvil Studio 2020.12.03 Apr 3, 2021
@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Apr 3, 2021
@ghost
Copy link

ghost commented Apr 3, 2021

This submission has moved to manual review.

@ghost ghost removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Apr 3, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Apr 3, 2021
@ghost ghost assigned KevinLaMS Apr 3, 2021
@ghost
Copy link

ghost commented Apr 3, 2021

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Apr 14, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Apr 14, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 7971dbc into microsoft:master Apr 14, 2021
@chausner chausner deleted the anvilstudio branch April 14, 2021 15:42
seejdev pushed a commit to seejdev/winget-pkgs that referenced this pull request Nov 4, 2021
@JohnMcPMS
Replace yaml-cpp with libyaml (microsoft#535)
dc7ed4d 
Due to certain bugs in yaml-cpp, it has not had significant fuzzing applied.  Even if those bugs were fixed, it is unknown how many more might exist behind it.  In order to avoid chasing those bugs, we are switching to a YAML parser that does have significant fuzz testing coverage, [libyaml](https://github.com/yaml/libyaml).

In addition to the use of libyaml, a C++ wrapper is written to create a near identical surface area for use by the existing manifest validation.  It also includes encoding detection to enable support for ANSI (assumed Windows-1252, which wasn't supported by yaml-cpp), UTF-8 (with and without BOM), UTF-16 LE/BE (both with and without BOM).

Finally, the `validate` command now returns a non-zero value when there are issues.  If there is a failure during validation, the value returned is `0x8A150029`.  If there are only warnings, the value returned is `0x8A150028`.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees

@KevinLaMS KevinLaMS

@denelon denelon

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chausner @wingetbot @KevinLaMS @denelon