Added IrfanView x64

[JudahGabriel]

Microsoft Reviewers: Open in CodeFlow

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

JudahGabriel The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the YAML file is compliant with the package manager specification (https://github.com/microsoft/appinstaller-pkgs/YAMLSpec.md)
For details on the error, see the error listed in the build pipeline.

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

JudahGabriel The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the YAML file is compliant with the package manager specification (https://github.com/microsoft/appinstaller-pkgs/YAMLSpec.md)
For details on the error, see the error listed in the build pipeline.

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

JudahGabriel The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the YAML file is compliant with the package manager specification (https://github.com/microsoft/appinstaller-pkgs/YAMLSpec.md)
For details on the error, see the error listed in the build pipeline.

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

JudahGabriel The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue. Please verify the installers are not malicious. If you feel this failure is in error, please file an issue.

[JudahGabriel]

@zachcarp I moved it to my own CDN, and now I'm getting an error saying the installer might be malicious.

Time to raise the white flag? I don't know what else to do here.

[zachcarp]

I wouldn't throw in the towel just yet. We are still in preview. This seems like a great opportunity.

[zachcarp]

@denelon Can you help take a look at this?

[denelon]

I'm also not able to locate a URL that points directly to the installer file.

[JudahGabriel]

I think there are 2 questions here:

1. How to make IrfanView work with winget, given no direct links to installers
2. Will Microsoft have its own CDN mirror for installers?

For the first question, I can just host the installer on my CDN: https://winget.b-cdn.net/iview454_setup.exe. However, now that I've done that, I'm seeing the above bot error:

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue. Please verify the installers are not malicious. If you feel this failure is in error, please file an issue.

I do feel it's in error. 😊 It's certainly not malicious. Can you fix the bot?

For the 2nd question, this would fix all the problems, right? Instead of relying on URLs which can break, slow, go down, or get hijacked by malicious parties, Microsoft maintains its own CDN of installers. It also fixes the issue where apps have no direct installer links. Is this planned?

[denelon]

@JudahGabriel I'm now getting an "Installer hash verification failed" error. You can use the winget client hash command to calculate the SHA256 for the installer.

[wingetbot]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ghost]

JudahGabriel The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue. Please verify the installers are not malicious. If you feel this failure is in error, please file an issue.
For details on the error, see the details link below in the build pipeline.

[JudahGabriel]

OK, I updated the manifest to use the zip file found on IrfanView site. And I ran winget validate [the .yml file] locally, and it said "Manifest validation succeeded"

However, pushing it here on GitHub says WinGetSvc-validation (manifest content validation) failed. No further details.

@denelon looks like it's being seen as malicious still. 😟

[chausner]

I think this currently fails due to multiple issues:

1. ZIP files are currently not supported so you should use the EXE installer instead.

2. The other problem is that there does not seem to exist any direct download link. The one that you specified that looks like a direct link still resolves to a landing page.

3. The validation bot currently does not seem to be compatible with websites that don't provide the file size in the response header (Content-Length), see https://dev.azure.com/ms/winget-pkgs/_build/results?buildId=79280&view=logs&jobId=c8020aa5-4aab-5881-691f-21986e02afd0&j=c8020aa5-4aab-5881-691f-21986e02afd0&t=bade86d6-d2be-5ddd-c1b9-7d8db9c4a60d:

   Error occurred during installer copy from https://www.irfanview.info/files/iview454_x64.zip.
    The Content-Length for the copy source is not specified.
   

[superusercode]

there is an official mirror for the installer at http://m.majorgeeks.com/files/details/irfanview_64.html

[JudahGabriel]

@superusercode is there a direct link to the installer? I don't see any on that page.

[superusercode]

The link is http://files2.majorgeeks.com/6467afde578ca6d96a9a3f62a7f5a68d5dd8ff51/graphics/iview454_x64_setup.exe

[JudahGabriel]

Thanks for the link there. Looks like that's not using any dynamic download tokens. I'll try using that link in the package. Woops, looks like that download no longer works. I suspect there's an expiration token in that URL that allowed it to work initially.

[JudahGabriel]

Looks like someone found a direct link to the installer and issued a working PR: #1208

Closing this; we should use that PR instead.