Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add UserAgent #43164

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix: Add UserAgent #43164

merged 1 commit into from
Jan 27, 2022

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Jan 26, 2022 •
edited by ghost
Loading

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@Trenly Trenly closed this Jan 26, 2022
@Trenly Trenly reopened this Jan 26, 2022
@Trenly
Copy link
Contributor Author

Trenly commented Jan 26, 2022

@denelon - Sorry for so many PR's for you

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 26, 2022
@vedantmgoyal9
Copy link
Contributor

Would there be any issue if PRs which change any .ps1 files under Tools folder are automatically merged same as manifests PRs?

@jedieaston
Copy link
Contributor

They should be looked over by someone from MS since they execute code on people's machines (the manifests do too, but there's an automated test suite for them).

@denelon
Copy link
Contributor

denelon commented Jan 27, 2022

@Trenly do you want me to go ahead and approve/merge this given the comment from @jedieaston?

@Trenly
Copy link
Contributor Author

Trenly commented Jan 27, 2022

@Trenly do you want me to go ahead and approve/merge this given the comment from @jedieaston?

It solves a few issues, and I'm planning a rewrite of the script later anyways, so I see no harm in merging this

@denelon denelon merged commit dc889c2 into microsoft:master Jan 27, 2022
@Trenly Trenly deleted the UserAgent branch January 27, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denelon denelon denelon approved these changes

@jedieaston jedieaston jedieaston approved these changes

Assignees
No one assigned
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Feature]: User-Agent
5 participants
@Trenly @wingetbot @vedantmgoyal9 @jedieaston @denelon