-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 1 of 2 'alpha'-designated version of 7-Zip from non-alpha listing #3762
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
peterlewis The package manager bot determined there was an issue with the pull request. Make sure the manifest file is under the manifests\publisher\appname. |
Have included removal of both alpha versions in a single PR. I'm aware from what @yigitemres mentioned that a single file change per PR is preferred, but not sure if that includes deletions, such as this. If it does then do just holler, and I'll split into two. |
Hey @KevinLaMS - Here's the other part of the 7-Zip change, i.e. removing the alpha releases from the main listing. |
@peterlewis Great, thanks. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hah, now you're testing my Git-fu! Think I've managed to do what is required, albeit followed by a revert and then a revert of the revert! :) |
This submission has moved to manual review. |
PR for the other file is in as #3807 |
Hello @KevinLaMS! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validation has completed
winget validate <manifest>
, where<manifest>
is the name of the manifest you're submitting?winget install -m <manifest>
?PR to follow #3756
Microsoft Reviewers: Open in CodeFlow