Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samsung USB Driver for Mobile Phones 1.7.31.0 is added. #2652

Closed
wants to merge 2 commits into from

Conversation

moolwalk
Copy link
Contributor

@moolwalk moolwalk commented Jul 28, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Silent install is not supported.

Microsoft Reviewers: Open in CodeFlow

moolwalk added 2 commits July 28, 2020 11:43
Silent option is removed because it's not supported.
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 28, 2020
@ghost
Copy link

ghost commented Jul 28, 2020

This submission has moved to manual review.

@ghost
Copy link

ghost commented Jul 28, 2020

Greetings moolwalk
During installation testing, this application failed to install with out user input. Did you forget to add Silent or SilentWithProgress switches?

Please investigate a fix and resubmit the Pull Request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jul 28, 2020
@moolwalk
Copy link
Contributor Author

Silent install is not supported. The failure that bot raised appears to be due to the installer needs to be run in Administrator privilege. Please move forward with this PR.

Jesse Ahn.

@moolwalk moolwalk removed their assignment Jul 29, 2020
@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs: Attention labels Jul 29, 2020
@ghost ghost removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Unattend-Failed labels Jul 29, 2020
@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 30, 2020
@denelon
Copy link
Contributor

denelon commented May 4, 2021

@moolwalk it looks like there are a few challenges here. We currently don't accept PRs for packages without support for a silent install. Many users are attempting to automate their environments, and we don't have the ability to filter on packages that require an interactive install yet.
microsoft/winget-cli#823

The feature to support the client requesting elevation for installers that don't do that on their own also hasn't been implemented.
microsoft/winget-cli#152

We've also updated to the manifest v1.0 schema.

Until all three of those issues have been addressed this package will not pass validation. I'm not sure if you would prefer to update the schema, and keep this PR open with the "Blocking-Issue" label so we can submit it once the issues are implemented, or close this PR.

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 11, 2021
@ghost
Copy link

ghost commented May 11, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this May 18, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. No-Recent-Activity No activity has occurred on this work item for seven days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants