-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gitlab-runner #2594
Add gitlab-runner #2594
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
zanseb The package manager bot determined there was an issue with the pull request. Make sure the ID is of the form publisher.appname and that the folder structure is publisher\appname. |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
This submission has moved to manual review. |
During installation testing, this app triggered a Microsoft Defender SmartScreen error. We are notifying [email protected] for investigation. |
There are 2 issues with this install.
|
@KevinLaMS, thanks for the feedback. Is it mandatory for the package to use a true installer, or is it planned to support such scenarios too? |
It should be covered under microsoft/winget-cli#194 or microsoft/winget-cli#182. |
@zanseb this PR is blocked by the .exe feature. It will also fail now as we have updated the manifest schema to v1.0. I'm not sure if you'd like to update the manifest or close this PR until we have support for standalone executables. |
@denelon I am fine w/ both options. What would you prefer? |
I think you've already done some of the heavy lifting to get the meta-data for the installer. If you don't mind updating the schema (knowing that it will fail validation), the community would benefit. The issue will be properly tagged so we can validate it once we have support for standalone executables, and nobody would need to go through the effort to gather the meta-data and submit a duplicate entry. Ultimately, it's up to you 😄 |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
manifests/g/Gitlab/gitlab-runner/13.2.0/Gitlab.gitlab-runner.yaml
Outdated
Show resolved
Hide resolved
InstallerSwitches: | ||
Silent: install | ||
SilentWithProgress: install | ||
ManifestType: singleton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be updated to the multi-manifest format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tired to split them. Have some trouble validating them locally (winget validate
). Can you hint me a resource in which the multi-manifest format is described? I only found https://docs.microsoft.com/en-us/windows/package-manager/package/manifest?tabs=minschema%2Cinstaller-example#multiple-manifest-files
manifests/g/Gitlab/gitlab-runner/13.2.0/Gitlab.gitlab-runner.yaml
Outdated
Show resolved
Hide resolved
Hello @zanseb, Template: msftbot/changesRequested |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Close with reason: Replaced by PR 70732 which is available at #70732; |
Apologies for over-topping your PR; Given that portable applications are still so new, we are still trying to figure out best-practices for all of the metadata in them to control how the version and name of the package gets mapped into the Add & Remove Programs table. I've used the data you included here in #70733. Thank you for your contribution and help! |
No worries! |
winget validate <manifest>
, where<manifest>
is the name of the manifest you're submitting?winget install -m <manifest>
?#1381
Microsoft Reviewers: Open in CodeFlow