Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitlab-runner #2594

Closed
wants to merge 9 commits into from
Closed

Add gitlab-runner #2594

wants to merge 9 commits into from

Conversation

zanseb
Copy link
Contributor

@zanseb zanseb commented Jul 23, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

#1381

Microsoft Reviewers: Open in CodeFlow

@KevinLaMS
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Jul 24, 2020
@ghost
Copy link

ghost commented Jul 24, 2020

zanseb The package manager bot determined there was an issue with the pull request. Make sure the ID is of the form publisher.appname and that the folder structure is publisher\appname.
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 24, 2020
@ghost ghost assigned KevinLaMS Jul 24, 2020
@ghost
Copy link

ghost commented Jul 24, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation label Jul 24, 2020
@ghost
Copy link

ghost commented Jul 24, 2020

During installation testing, this app triggered a Microsoft Defender SmartScreen error.

We are notifying [email protected] for investigation.

@ghost ghost added Needs SmartScreen Investigation and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jul 24, 2020
@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. and removed PullRequest-Error PR is Invalid Needs SmartScreen Investigation Validation-SmartScreen Microsoft Defender SmartScreen triggered during manual validation labels Jul 24, 2020
@KevinLaMS
Copy link
Contributor

There are 2 issues with this install.

  1. you must be an admin. by default it fails with exit code 1.
  2. it seems to be an executable that runs, rather than a true installer.

@zanseb
Copy link
Contributor Author

zanseb commented Jul 27, 2020

@KevinLaMS, thanks for the feedback. Is it mandatory for the package to use a true installer, or is it planned to support such scenarios too?

@denelon
Copy link
Contributor

denelon commented Sep 22, 2020

It should be covered under microsoft/winget-cli#194 or microsoft/winget-cli#182.

@denelon denelon added the .exe label May 4, 2021
@denelon
Copy link
Contributor

denelon commented May 4, 2021

@zanseb this PR is blocked by the .exe feature. It will also fail now as we have updated the manifest schema to v1.0. I'm not sure if you'd like to update the manifest or close this PR until we have support for standalone executables.

@zanseb
Copy link
Contributor Author

zanseb commented May 4, 2021

@denelon I am fine w/ both options. What would you prefer?

@denelon
Copy link
Contributor

denelon commented May 4, 2021

I think you've already done some of the heavy lifting to get the meta-data for the installer. If you don't mind updating the schema (knowing that it will fail validation), the community would benefit. The issue will be properly tagged so we can validate it once we have support for standalone executables, and nobody would need to go through the effort to gather the meta-data and submit a duplicate entry. Ultimately, it's up to you 😄

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation labels Aug 18, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-No-Executables labels Aug 18, 2022
@ghost ghost assigned florelis and msftrubengu Aug 18, 2022
InstallerSwitches:
Silent: install
SilentWithProgress: install
ManifestType: singleton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be updated to the multi-manifest format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tired to split them. Have some trouble validating them locally (winget validate). Can you hint me a resource in which the multi-manifest format is described? I only found https://docs.microsoft.com/en-us/windows/package-manager/package/manifest?tabs=minschema%2Cinstaller-example#multiple-manifest-files

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Aug 18, 2022
@ghost ghost assigned zanseb Aug 18, 2022
@ghost
Copy link

ghost commented Aug 18, 2022

Hello @zanseb,
The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@ghost ghost removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Aug 18, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 18, 2022
@ghost ghost removed Validation-No-Executables Needs-Author-Feedback This needs a response from the author. labels Aug 18, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ItzLevvie
Copy link
Contributor

ItzLevvie commented Aug 18, 2022

Close with reason: Replaced by PR 70732 which is available at #70732;

@ghost ghost closed this Aug 18, 2022
@Trenly
Copy link
Contributor

Trenly commented Aug 18, 2022

Apologies for over-topping your PR; Given that portable applications are still so new, we are still trying to figure out best-practices for all of the metadata in them to control how the version and name of the package gets mapped into the Add & Remove Programs table.

I've used the data you included here in #70733. Thank you for your contribution and help!

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 18, 2022
@zanseb
Copy link
Contributor Author

zanseb commented Aug 18, 2022

No worries!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants