Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vagrant 2.2.9 manifest #2328

Closed
wants to merge 2 commits into from
Closed

Conversation

mizutoki79
Copy link
Contributor

@mizutoki79 mizutoki79 commented Jul 6, 2020

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate <manifest>, where <manifest> is the name of the manifest you're submitting?
  • Have you tested your manifest locally with winget install -m <manifest>?

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 6, 2020
@ghost
Copy link

ghost commented Jul 6, 2020

This submission has moved to manual review.

@ghost ghost assigned denelon Jul 6, 2020
@KevinLaMS KevinLaMS added the Validation-Installation-Error Error installing application label Jul 6, 2020
@ghost
Copy link

ghost commented Jul 6, 2020

mizutoki79 The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jul 6, 2020
@KevinLaMS
Copy link
Contributor

Installation causes automatic reboot. This is unexpected.

@mizutoki79
Copy link
Contributor Author

/promptrestart switch didn't work.
/norestart switch suppressed restart, but winget say Installer failed with exit code: 3010.
I think we need to allow 3010 in winget-cli for this installation to succeed.

@ghost ghost removed the Needs: author feedback label Jul 7, 2020
@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 22, 2020
@KevinLaMS
Copy link
Contributor

microsoft/winget-cli#137

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application labels Aug 30, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Aug 30, 2020
@ghost ghost assigned KevinLaMS Aug 30, 2020
@ghost
Copy link

ghost commented Aug 30, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added Blocking-Issue Manifest validation is blocked by a known issue. and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Sep 1, 2020
@KevinLaMS
Copy link
Contributor

still blocked on error code.

@denelon
Copy link
Contributor

denelon commented May 4, 2021

We now support non-zero exit codes with the new manifest schema 😄

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 11, 2021
@ghost
Copy link

ghost commented May 11, 2021

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this May 18, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. No-Recent-Activity No activity has occurred on this work item for seven days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants