Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pixel-point.kube-forwarder version 1.5.1 #22044

Merged
2 commits merged into from
Jul 24, 2021
Merged

pixel-point.kube-forwarder version 1.5.1 #22044

2 commits merged into from
Jul 24, 2021

Conversation

oxygen-dioxide
Copy link
Contributor

@oxygen-dioxide oxygen-dioxide commented Jul 22, 2021 •
edited by ghost
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jul 22, 2021
@ghost ghost assigned oxygen-dioxide Jul 22, 2021
@ghost
Copy link

ghost commented Jul 22, 2021

Hello @oxygen-dioxide,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 22, 2021
OfficialEsco
OfficialEsco approved these changes Jul 22, 2021
View reviewed changes
Copy link
Contributor

@OfficialEsco OfficialEsco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nullsoft no prompt, close and reopen this PR

@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 22, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jul 22, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Jul 22, 2021
@ghost
Copy link

ghost commented Jul 22, 2021

Hello @oxygen-dioxide,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Jul 22, 2021
@OfficialEsco OfficialEsco mentioned this pull request Jul 23, 2021
Closed
@ghost ghost removed Needs: author feedback Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Jul 23, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Static-Scan The test that runs static analysis failed. label Jul 23, 2021
@ghost
Copy link

ghost commented Jul 23, 2021

Hello @oxygen-dioxide,
The pull request encountered an internal error and has been assigned to a developer to investigate.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed Internal-Error-Static-Scan The test that runs static analysis failed. Needs: Attention labels Jul 24, 2021
@wingetbot wingetbot added the Internal-Error-Static-Scan The test that runs static analysis failed. label Jul 24, 2021
@ghost
Copy link

ghost commented Jul 24, 2021

Hello @oxygen-dioxide,
The pull request encountered an internal error and has been assigned to a developer to investigate.

@ghost ghost added the Needs: Attention label Jul 24, 2021
@ghost ghost assigned ranm-msft Jul 24, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed Internal-Error-Static-Scan The test that runs static analysis failed. Needs: Attention labels Jul 24, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 24, 2021
@ghost
Copy link

ghost commented Jul 24, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 24, 2021
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 24, 2021
@ghost
Copy link

ghost commented Jul 24, 2021

Hello @oxygen-dioxide,
Validation has completed.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 24, 2021
@ghost
Copy link

ghost commented Jul 24, 2021

Hello @oxygen-dioxide,
Validation has completed.

@ghost ghost merged commit 488d3a6 into microsoft:master Jul 24, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OfficialEsco OfficialEsco OfficialEsco approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oxygen-dioxide @wingetbot @OfficialEsco @ranm-msft