Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: SBRW.NFSW_GameLauncher version 2.2.2 #198541

Conversation

MeTonaTOR
Copy link

@MeTonaTOR MeTonaTOR commented Dec 12, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@MeTonaTOR
Copy link
Author

@microsoft-github-policy-service agree company="SBRW"

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 12, 2024
@stephengillie
Copy link
Collaborator

Hi @MeTonaTOR,

Manual Validation ended with:
image

Is a dependency needed?

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Dec 13, 2024
@stephengillie
Copy link
Collaborator

Verify while here:
image

@Trenly
Copy link
Contributor

Trenly commented Dec 13, 2024

[Policy] zip-binary

@microsoft-github-policy-service microsoft-github-policy-service bot added the zip-binary Depends on library files that aren't available via symlink label Dec 13, 2024
@MeTonaTOR
Copy link
Author

Hey @stephengillie

Yes, this file is actually optional, it was used on older method of obtaining compressed chunks of data. Now it mostlu fetches one single zip-compressed chunk of data that executable itself can manage to extract

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 13, 2024
@Trenly
Copy link
Contributor

Trenly commented Dec 19, 2024

Hey @stephengillie

Yes, this file is actually optional, it was used on older method of obtaining compressed chunks of data. Now it mostlu fetches one single zip-compressed chunk of data that executable itself can manage to extract

Even though it says it downloaded the file, any time I attempt to start the installer it gives the same message and never actually launches

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 19, 2024
@stephengillie stephengillie added Installation-Validation-Error The test designed to verify the package installer ran correctly failed. and removed Validation-Completed Validation passed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Dec 24, 2024
@MeTonaTOR MeTonaTOR closed this Dec 26, 2024
auto-merge was automatically disabled December 26, 2024 10:56

Pull request was closed

@MeTonaTOR MeTonaTOR deleted the SBRW.NFSW_GameLauncher-2.2.2-a66e63f0-5655-4b2b-97fe-fa855d36df80 branch December 26, 2024 10:56
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Installation-Validation-Error The test designed to verify the package installer ran correctly failed. New-Package No-Recent-Activity No activity has occurred on this work item for seven days. zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants