Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Genymobile.scrcpy version 3.0 #196164

Conversation

ponces
Copy link
Contributor

@ponces ponces commented Dec 4, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Dec 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Dec 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Dec 4, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 4, 2024
@wingetbot
Copy link
Collaborator

Found duplicate pull request(s)

@ponces
Copy link
Contributor Author

ponces commented Dec 4, 2024

Found duplicate pull request(s)

Please, disregard this as the other pull requests are not bumping the manifest version which enables the use of the ArchiveBinariesDependOnPath property which fixes a known DLL missing issue.

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

No errors to post.

(Automated response - build 899.)

@Ayx03
Copy link

Ayx03 commented Dec 5, 2024

Ok I'll close those as you've bumped the manifest version, I'm just trying if the new versions of the automated tools will bump the manifest version or can they pass and just get 3.0 on winget. Btw newer versions of scrcpy has been released.

@ponces
Copy link
Contributor Author

ponces commented Dec 5, 2024

After merging this, I can push a manifest for each of those new versions (3.0.1 and 3.0.2 right?).

@stephengillie stephengillie added Validation-Completed Validation passed Retry-1 flag to indicate retried Possible-Duplicate and removed Validation-Executable-Error Retry-1 flag to indicate retried Possible-Duplicate labels Dec 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit f9ae38f into microsoft:master Dec 6, 2024
2 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Possible-Duplicate Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants