-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: Xiph.FLAC version 1.4.3 #194574
New package: Xiph.FLAC version 1.4.3 #194574
Conversation
/AzurePipelines run |
3735f6b
to
cc6b444
Compare
/AzurePipelines run |
Dear winget team, this particular manifest requires features introduced in the v1.9.0 manifest version, specifically microsoft/winget-cli#4816 Based on what I can see, no other manifests in this repository use this new feature I can confirm however that this does work as expected on the latest Windows 11 24H2. I'm happy for this PR to stay open until such time than the v1.9.0 manifest format is allowed if required. Cheers |
cc6b444
to
d097850
Compare
/AzurePipelines run |
Hey there, the links used are those which I'm directed to by the official FLAC site.
The download is also available via releases on the official GitHub repository if that's preferred. Cheers |
@stephengillie Hey there, would you kindly let me know what is required for this PR to be merged please? Thanks heaps |
I'm unaware what further information is required here. @Trenly @stephengillie Can you kindly provide me some guidance so we can get this completed please? Cheers |
@denelon Sorry to tag you in, but this is relatively similar to the PR for the LAME MP3 encoder which you helped me with. The downloads linked to by the official FLAC site technically reside at a different domain. As I mentioned above, the source code and release binaries are also published on GitHub on the official flac repo, so I'm happy to switch to that dowload if it's preferred (they are identical as compared via checksums here), but the website dowlnoad link does direct you to the links I used. |
@stephengillie should be able to verify the URL for the downloads is referenced by the product site. Once that's been confirmed, we'll be able to add a waiver to approve. |
Thank you so much for the merge! Cheers |
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the directory's name containing the manifest you're submitting.Resolves #151382
Microsoft Reviewers: Open in CodeFlow