Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Xiph.FLAC version 1.4.3 #194574

Conversation

fgimian
Copy link
Contributor

@fgimian fgimian commented Nov 27, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema? No, this particular package requires the 1.9.0 manifest version, see comment below for further information 😄

Note: <path> is the directory's name containing the manifest you're submitting.

Resolves #151382


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@fgimian fgimian force-pushed the Xiph.FLAC-1.4.3-d7a14a5b-ee2b-428b-8731-bb4e85c13e6b branch from 3735f6b to cc6b444 Compare November 27, 2024 09:06
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. zip-binary Depends on library files that aren't available via symlink Needs-Author-Feedback This needs a response from the author. labels Nov 27, 2024
@fgimian
Copy link
Contributor Author

fgimian commented Nov 27, 2024

Dear winget team, this particular manifest requires features introduced in the v1.9.0 manifest version, specifically microsoft/winget-cli#4816

Based on what I can see, no other manifests in this repository use this new feature ArchiveBinariesDependOnPath: true nor the v1.9.0 manifest version. I presume it's too early to start using these features, is that correct?

I can confirm however that this does work as expected on the latest Windows 11 24H2. I'm happy for this PR to stay open until such time than the v1.9.0 manifest format is allowed if required.

Cheers
Fotis

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 27, 2024
@fgimian fgimian force-pushed the Xiph.FLAC-1.4.3-d7a14a5b-ee2b-428b-8731-bb4e85c13e6b branch from cc6b444 to d097850 Compare November 27, 2024 09:45
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. and removed Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 27, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain Validation-Executable-Error labels Nov 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 27, 2024
@fgimian
Copy link
Contributor Author

fgimian commented Nov 27, 2024

Hello @fgimian,

One or more of the installer URLs doesn't appear valid.

This may happen for sites with policies prohibiting distribution or use by third parties.

This may happen for URLs pointing to domains that do not align with the publisher domain or package domain. If you could provide supporting evidence from the publisher that the URLs for the installer are correct, that would help us to validate and approve this PR.

Template: msftbot/validationError/urls/domain

Hey there, the links used are those which I'm directed to by the official FLAC site.

  1. Browse to https://xiph.org/flac/download.html
  2. Under Windows, click FLAC for Windows
  3. You'll be redirected to https://ftp.osuosl.org/pub/xiph/releases/flac/ with the downloads

The download is also available via releases on the official GitHub repository if that's preferred.

Cheers
Fotis

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 27, 2024
@fgimian
Copy link
Contributor Author

fgimian commented Nov 29, 2024

@stephengillie Hey there, would you kindly let me know what is required for this PR to be merged please?

Thanks heaps
Fotis

@microsoft-github-policy-service microsoft-github-policy-service bot removed Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package labels Dec 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 3, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Domain Validation-Executable-Error labels Dec 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Dec 9, 2024
@fgimian
Copy link
Contributor Author

fgimian commented Dec 9, 2024

Hello @fgimian,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

I'm unaware what further information is required here. @Trenly @stephengillie Can you kindly provide me some guidance so we can get this completed please?

Cheers
Fotis

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed No-Recent-Activity No activity has occurred on this work item for seven days. Needs-Author-Feedback This needs a response from the author. labels Dec 9, 2024
@fgimian
Copy link
Contributor Author

fgimian commented Dec 9, 2024

@denelon Sorry to tag you in, but this is relatively similar to the PR for the LAME MP3 encoder which you helped me with. The downloads linked to by the official FLAC site technically reside at a different domain. As I mentioned above, the source code and release binaries are also published on GitHub on the official flac repo, so I'm happy to switch to that dowload if it's preferred (they are identical as compared via checksums here), but the website dowlnoad link does direct you to the links I used.

@denelon
Copy link
Contributor

denelon commented Dec 9, 2024

@stephengillie should be able to verify the URL for the downloads is referenced by the product site. Once that's been confirmed, we'll be able to add a waiver to approve.

@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Executable-Error Validation-Domain Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 10, 2024
@stephengillie stephengillie enabled auto-merge (squash) December 10, 2024 00:22
@stephengillie stephengillie merged commit 50d6e47 into microsoft:master Dec 10, 2024
2 checks passed
@fgimian fgimian deleted the Xiph.FLAC-1.4.3-d7a14a5b-ee2b-428b-8731-bb4e85c13e6b branch December 10, 2024 00:55
@fgimian
Copy link
Contributor Author

fgimian commented Dec 10, 2024

Thank you so much for the merge!

Cheers
Fotis

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: flac
5 participants