Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rio terminal #184792

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Conversation

raphamorim
Copy link
Contributor

@raphamorim raphamorim commented Oct 21, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@raphamorim
Copy link
Contributor Author

@microsoft-github-policy-service agree

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Oct 21, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Oct 21, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Oct 21, 2024
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Oct 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 21, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Oct 21, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Oct 21, 2024

Automatic Validation ended with:
Edit:

{
    "$id": "1",
    "innerException": null,
    "message": "Artifact InstallationVerificationLogs was not found for build 16875.",
    "typeName": "Microsoft.TeamFoundation.Build.WebApi.ArtifactNotFoundException, Microsoft.TeamFoundation.Build2.WebApi",
    "typeKey": "ArtifactNotFoundException",
    "errorCode": 0,
    "eventId": 3000
}

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Manifest-Version-Deprecated This manifest schema version is deprecated. The PR should be updated. Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Oct 21, 2024
@wingetbot
Copy link
Collaborator

Manifest Schema Version: 1.1.0 less than 1.5.0 for ID: raphamorim.rio and Version: 0.1.16

@raphamorim
Copy link
Contributor Author

Updated @stephengillie 🙏

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 22, 2024
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 22, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Oct 22, 2024

Verify:
image
image
I couldn't find how to have the application display its version number.
image

Edit: I used this package to approve this PR.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Oct 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 56dca7d into microsoft:master Oct 22, 2024
2 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manifest-Version-Deprecated This manifest schema version is deprecated. The PR should be updated. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants