Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: - VictorIX.BlenderLauncher version 2.2.0 #172582

Conversation

jo-chemla
Copy link
Contributor

@jo-chemla jo-chemla commented Sep 10, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Note I'm getting an error when trying to install locally, which appears to be widespread #152915

C:\Users\jonathan\Downloads\winget-custom-komac>winget install --manifest VictorIX\BlenderLauncher\2.2.0\
Found Blender Launcher [VictorIX.BlenderLauncher] Version 2.2.0
La licence d’utilisation de cette application vous est octroyée par son propriétaire.
Microsoft n’est pas responsable des paquets tiers et n’accorde pas de licences à ceux-ci.
Downloading https://github.com/Victor-IX/Blender-Launcher-V2/releases/download/v2.2.0/Blender_
Unexpected error occurred while running command : (Une erreur inattendue s'est produite lors de l'exécution de la commande )
Download request status is not success.
0x80190194 : Not found (404).
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jo-chemla
Copy link
Contributor Author

@microsoft-github-policy-service agree

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 10, 2024
@jo-chemla
Copy link
Contributor Author

@microsoft-github-policy-service agree

@stephengillie
Copy link
Collaborator

Verify:
image
image
image
image

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 85aef93 into microsoft:master Sep 10, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 10, 2024
@jo-chemla
Copy link
Contributor Author

jo-chemla commented Sep 10, 2024

Thanks for merging!
Also, the -set-library-folder could be exposed to the winget install options? Not sure how I could do that.

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@jo-chemla
Copy link
Contributor Author

jo-chemla commented Sep 10, 2024

Thanks, I managed to install it via winget install VictorIX.BlenderLauncher, and it ends-up indeed into C:/Users/username/AppData/Local/Microsoft/Winget/Links

However, searching for it in the windows start-menu does not return "Blender launcher.exe". Is there a specific configuration to add the exe to the start-menu search? It seems that this is linked to see feature-request microsoft/winget-cli#2299, adding start-menu entries for GUI applications.

@jo-chemla jo-chemla changed the title New package: WIP - VictorIX.BlenderLauncher version 2.2.0 New package: - VictorIX.BlenderLauncher version 2.2.0 Sep 11, 2024
@jo-chemla jo-chemla deleted the VictorIX.BlenderLauncher-2.2.0-ECB7AC3613284B85842C2B814D90387C branch November 19, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants