Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kiwix.kiwixjs version 1.3.2.0 #16129

Conversation

oxygen-dioxide
Copy link
Contributor

@oxygen-dioxide oxygen-dioxide commented Jun 4, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 4, 2021
@Jaifroid
Copy link
Contributor

Jaifroid commented Jun 4, 2021

@oxygen-dioxide Thank you for submitting Kiwix JS Windows to the WinGet repo. As the developer of Kiwix JS Windows, I was about to do the same thing, when I saw your submission. I note you've put as the package URL the permalink. I think this might be an issue because when I update the package, the permalink will change and so will the SHA. This will cause installation errors. I think it would be better for me to create this submission using the GitHub repository instead, which is versioned. I will also be able to add the proper locale data.

Could you close this PR without merging, and I will create one, which I can then keep up to date as part of the package creation script?

Many thanks.

@Jaifroid
Copy link
Contributor

Jaifroid commented Jun 4, 2021

@oxygen-dioxide please see PR #16135 which I have created with a properly versioned package.

@denelon
Copy link
Contributor

denelon commented Jun 4, 2021

@Jaifroid you might want to take a look at https://github.com/microsoft/winget-create. It is still a very early preview, but was designed with CI/CD scenarios in mind to help automate the process of generating manifests and submitting PRs for these packages. We also have a feature in progress for "verified publisher(s)" to prevent others from making changes to manifests. The current thinking is to inform the author of the PR (and possibly the verified owner). Then the bot would close the PR.

@Jaifroid
Copy link
Contributor

Jaifroid commented Jun 4, 2021

@denelon I actually did use winget-create for the PR that replaces this one: #16135 . I'll be using it in CI/CD for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants