Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting Zeal version 0.6.1.yaml #1550

Closed
wants to merge 3 commits into from
Closed

Conversation

jtn70
Copy link

@jtn70 jtn70 commented Jun 3, 2020

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jun 3, 2020
@ghost
Copy link

ghost commented Jun 3, 2020

jtn70 The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the manifest file is compliant with the package manager specification (https://docs.microsoft.com/windows/package-manager/package)
For details on the error, see the details link below in the build pipeline.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

1 similar comment
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label Jun 3, 2020
@ghost
Copy link

ghost commented Jun 3, 2020

jtn70 The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

Here are some common causes for this failure you should consider:

  1. The Sha256 HASH in the manifest does not match the HASH of the installer. Run winget hash to generate the hash.
  2. The URL is not valid. Make sure the URL to the installer is publicly available and valid.
  3. The installer has been identified as malware. If the installer is detected as malware, you can submit the installer to the defender team for analysis as a potential false positive.

@wingetbot wingetbot added Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. and removed Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. Needs: author feedback labels Jun 3, 2020
@ghost
Copy link

ghost commented Jun 3, 2020

jtn70 The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

Here are some common causes for this failure you should consider:

  1. The Sha256 HASH in the manifest does not match the HASH of the installer. Run winget hash to generate the hash.
  2. The URL is not valid. Make sure the URL to the installer is publicly available and valid.
  3. The installer has been identified as malware. If the installer is detected as malware, you can submit the installer to the defender team for analysis as a potential false positive.

@jtn70
Copy link
Author

jtn70 commented Jun 3, 2020

This is caused by #259 Support HTTP redirects better, the installer file uses https://dl.bintray.com/

@ghost ghost removed the Needs: author feedback label Jun 3, 2020
@SoftCreatR
Copy link
Contributor

SoftCreatR commented Jun 5, 2020

@jtn70 Until this has been fixed, use this url instead:

https://www.winget.it/dl/1fd014181789c0ec6beeaa04085b2a7dc27f0868bd9e4ac0fe0d2dd74b053dca/https%3A%2F%2Fdl.bintray.com%2Fzealdocs%2Fwindows%2Fzeal-0.6.1-windows-x64.msi

@wingetbot wingetbot removed the Binary-Validation-Error An error was encountered during the Installers Scan pipeline step. label Jun 8, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jun 8, 2020
@ghost
Copy link

ghost commented Jun 8, 2020

This submission has moved to manual review.

@ghost
Copy link

ghost commented Jun 8, 2020

Greetings. This package fails because it is dependent on the Visual Studio Runtime and we do not support the dependencies yet. See issue: microsoft/winget-cli#163

In the meantime, if you include the dependencies in your package, it should pass.
https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads

@ghost ghost added Needs: author feedback Blocking-Issue Manifest validation is blocked by a known issue. and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Jun 8, 2020
@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jun 16, 2020
@ghost
Copy link

ghost commented Jun 16, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this Jun 23, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. No-Recent-Activity No activity has occurred on this work item for seven days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants