Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Corel.WinZip to 28.0.15640 #151794

Merged

Conversation

FaserF
Copy link
Contributor

@FaserF FaserF commented May 1, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


This is another try of the old PR #138830 where only the PackageDependencies failed.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-05-01 05:27:48.827 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFD54FFC11F: (caller: 00007FFD54D88D6F) LogHr(1) tid(a34) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFD54F02B08: (caller: 00007FFD54FABC20) Exception(1) tid(a34) 8A15005E ]
2024-05-01 05:27:48.827 [REPO] Failed to open available source: msstore
2024-05-01 05:27:57.087 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFD3E31C11F: (caller: 00007FFD3E0A8D6F) LogHr(1) tid(1454) 8A15005E Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFD3E222B08: (caller: 00007FFD3E2CBC20) Exception(1) tid(1454) 8A15005E ]
2024-05-01 05:27:57.087 [REPO] Failed to open available source: msstore
2024-05-01 05:29:01.820 [CLI ] ShellExecute installer failed: 1603
Property(S): ErrorDialog = SetupError
Property(S): S_ERROR_TITLE = WinZip Install Error
Property(S): WinZipErrorPageUrl = http://www.winzip.com/wzgate.cgi?lang=EN&url=www.winzip.com/net4update.html
MSI (s) (68:1C) [05:29:01:661]: Product: WinZip 28.0 -- Installation operation failed.

Automated error analysis suggests 1603 may mean Install successful but system restart may be required.

Automated error analysis suggests -1978335226 may mean Install successful but system restart may be required.

(Automated response - build 878.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 6, 2024
@FaserF
Copy link
Contributor Author

FaserF commented May 6, 2024

Looks top me like a dependency issue and not a package issue

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed No-Recent-Activity No activity has occurred on this work item for seven days. Needs-Author-Feedback This needs a response from the author. labels May 6, 2024
@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Shell-Execute labels May 7, 2024
@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label May 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 7, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installer Verification Analysis Context Information:
Specified hash doesn't match.
Actual hash: 2FA967895ADEDA18C1FC3C34C3C46CFC9660695ACFA668CA591E2CE8B0F1DE93
Expected hash: 729df905fd1086d611042689117d78a0b5ad7a7b2d29bba291eb36d9233c69fb

5/7/2024 12:17:26 AM


Installer Validation


(Automated response - build 880.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label May 12, 2024
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label May 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 13, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-05-12 22:21:25.310 [REPO] Failed to open available source: msstore
2024-05-12 22:21:33.819 [REPO] Failed to open available source: msstore
2024-05-12 22:22:47.783 [CLI ] ShellExecute installer failed: 1603
Property(S): ErrorDialog = SetupError
Property(S): S_ERROR_TITLE = WinZip Install Error
Property(S): WinZipErrorPageUrl = http://www.winzip.com/wzgate.cgi?lang=EN&url=www.winzip.com/net4update.html
MSI (s) (A0:40) [22:22:47:525]: Product: WinZip 28.0 -- Installation operation failed.

Automated error analysis suggests 1603 may mean Install successful but system restart may be required.

Automated error analysis suggests -1978335226 may mean Install successful but system restart may be required.

(Automated response - build 880.)

@FaserF
Copy link
Contributor Author

FaserF commented May 14, 2024

This is a bug with Winget itself, right?
This package does not need msstore, still this error occurs:

Failed to open available source: msstore

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 14, 2024
@stephengillie
Copy link
Collaborator

This is a bug with Winget itself, right? This package does not need msstore, still this error occurs:

Failed to open available source: msstore

I think this might be looking up the dependency. I'm not sure. This specific line seems to occur frequently without any corellation to a specific error, so I think I'll add it to the "filter out" list.

  • There was a suggestion to remove this source from validation, "to reduce the log load here."

For the exit code and Shellexeute installer codes, should 1603 be added as an InstallerSuccessCode or similar?

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 14, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels May 16, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) May 16, 2024 08:21
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 02ef9a1 into microsoft:master May 16, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 16, 2024
@FaserF FaserF deleted the update-winzip branch May 16, 2024 17:36
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants