Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: SABnzbdTeam.SABnzbd.Portable version 4.2.3 #150298

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Apr 20, 2024

Pull request has been created with komac v2.2.1 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Apr 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 20, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Apr 21, 2024
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Apr 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 21, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Apr 21, 2024
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Apr 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 21, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Apr 22, 2024

Automatic Validation ended with:

Manifest Error: Schema Error. [Schema validation failed. Error context: [Installers][0][NestedInstallerType] Description: Failed to match against any enum values. Error context: [Installers][0] Description: Failed to validate against schema associated with property name 'NestedInstallerType'. Error context: [Installers] Description: Failed to validate item #0 in array. Error context: [Installers][1][NestedInstallerType] Description: Failed to match against any enum values. Error context: [Installers][1] Description: Failed to validate against schema associated with property name 'NestedInstallerType'. Error context: [Installers] Description: Failed to validate item #1 in array. Error context: Description: Failed to validate against schema associated with property name 'Installers'. ] File: SABnzbdTeam.SABnzbd.Potable.installer.yaml Manifest Error: Invalid field value. [InstallerType] Manifest Error: Required field missing. [NestedInstallerType] Manifest Error: Only one entry for NestedInstallerFiles can be specified for non-portable InstallerTypes. [NestedInstallerFiles] Manifest Error: Invalid field value. [InstallerType] Manifest Error: Required field missing. [NestedInstallerType] Manifest Error: Only one entry for NestedInstallerFiles can be specified for non-portable InstallerTypes. [NestedInstallerFiles]

Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CoolPlayLin,

It seems there might have been a typo. This might not have been caught by the spelling check because potable fit to drink is still a valid English word.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. Changes-Requested Changes Requested labels Apr 26, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@CoolPlayLin CoolPlayLin changed the title New package: SABnzbdTeam.SABnzbd.Potable version 4.2.3 New package: SABnzbdTeam.SABnzbd.Portable version 4.2.3 Apr 26, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 26, 2024 13:36
@stephengillie
Copy link
Collaborator

stephengillie commented Apr 26, 2024

Manual Validation ended with:
image

Edit: But the full application launched normally (inside the browser).

@stephengillie stephengillie added the zip-binary Depends on library files that aren't available via symlink label Apr 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Apr 26, 2024
@Trenly
Copy link
Contributor

Trenly commented Dec 3, 2024

@CoolPlayLin - Support for zipped binaries has now been added and is available in the pipelines. This will require you to update your submission to ManifestVersion: 1.9.0 and set ArchiveBinariesDependOnPath: true in the installer node. To keep things clean, this PR is being closed. Please submit a new PR for the latest version of this package. Thank you for your contributions!

auto-merge was automatically disabled December 3, 2024 23:10

Pull request was closed

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. New-Package Validation-Completed Validation passed zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants