Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Microsoft.Promptflow version 1.8.0 #148606

Conversation

YingChen1996
Copy link
Contributor

@YingChen1996 YingChen1996 commented Apr 11, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. Manifest-Path-Error This label indicates that the PR was not placed in the manifest folder. and removed Needs-Author-Feedback This needs a response from the author. Unexpected-File labels Apr 11, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Apr 11, 2024
@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 11, 2024 06:01
@YingChen1996
Copy link
Contributor Author

issue: #148628

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit ddccc23 into microsoft:master Apr 11, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't want to block PR based on these nits, but I'll be fixing these in a separate PR

cc @YingChen1996

- Command-Line
- pf
- pfazure
InstallationNotes: Winget installs the 64-bit CLI on 64-bit OS by default now
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like the right use case for InstallationNotes

Copyright: Copyright (C) Microsoft Corporation.
CopyrightUrl: https://github.com/microsoft/promptflow/blob/main/LICENSE
ShortDescription: Prompt flow is a suite of development tools designed to streamline the end-to-end development cycle of LLM-based AI applications, from ideation, prototyping, testing, evaluation to production deployment and monitoring.
Description: Prompt flow is a suite of development tools designed to streamline the end-to-end development cycle of LLM-based AI applications, from ideation, prototyping, testing, evaluation to production deployment and monitoring. It makes prompt engineering much easier and enables you to build LLM apps with production quality.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extended description should not match the short description

Description: Prompt flow is a suite of development tools designed to streamline the end-to-end development cycle of LLM-based AI applications, from ideation, prototyping, testing, evaluation to production deployment and monitoring. It makes prompt engineering much easier and enables you to build LLM apps with production quality.
Moniker: pf
Tags:
- Command-Line
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags should be lowercase

DisplayInstallWarnings: true
AppsAndFeaturesEntries:
- DisplayName: promptflow (64-bit)
UpgradeCode: 772aa21f-f8d4-4771-b910-1dbce3f1920c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be written as '{772AA21F-F8D4-4771-B910-1DBCE3F1920C}'

@mdanish-kh
Copy link
Contributor

mdanish-kh commented Apr 11, 2024

Also noticed the Scope value should not be set to user based on how WinGet handles user-scope MSIs at the moment (microsoft/winget-cli#3011). Scope: user will block winget upgrade for this package. I've removed it in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manifest-Path-Error This label indicates that the PR was not placed in the manifest folder. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants