Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NuGet workaround for Sandbox Test #141319

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Feb 28, 2024

Since the dependency was bumped, SandboxTest is broken currently. With the appx files not being available on GitHub, the NuGet package must be used to install them. This PR adds the NuGet package and associated behavior for extracting and installing Microsoft.UI.Xaml.2.8. This necessitated installing each of the dependencies separately instead of using -DependencyPath as the install would error out otherwise.

Microsoft.UI.Xaml.2.7 must be retained for backwards compatibility in case a user wishes to utilize the -WinGetVersion option.

cc @jedieaston @mdanish-kh @denelon

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Feb 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Feb 28, 2024
@Trenly
Copy link
Contributor Author

Trenly commented Feb 28, 2024

@stephengillie

@denelon denelon merged commit 636d4e3 into microsoft:master Feb 28, 2024
1 check passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Project-File
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants