Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent auto restart after LibreOffice install #1210

Merged
1 commit merged into from
Jun 3, 2020
Merged

Prevent auto restart after LibreOffice install #1210

1 commit merged into from
Jun 3, 2020

Conversation

SoftCreatR
Copy link
Contributor

@SoftCreatR SoftCreatR commented May 27, 2020 •
edited
Loading

n/t

Resolves #1154

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 27, 2020
@ghost ghost assigned samiranshah-zz May 27, 2020
@ghost
Copy link

ghost commented May 27, 2020

This submission has moved to manual review.

Reset816
Reset816 previously approved these changes May 27, 2020
View reviewed changes
noxifoxi
noxifoxi previously approved these changes May 27, 2020
View reviewed changes
@SoftCreatR SoftCreatR closed this May 29, 2020
@SoftCreatR SoftCreatR deleted the patch-1 branch May 29, 2020 06:32
@Reset816
Copy link
Contributor

why you close the PR? It has't been merged.

@SoftCreatR SoftCreatR restored the patch-1 branch May 29, 2020 06:53
@SoftCreatR SoftCreatR reopened this May 29, 2020
@SoftCreatR
Copy link
Contributor Author

SoftCreatR commented May 29, 2020 •
edited
Loading

why you close the PR? It has't been merged.

@reset12138 Accident ;)

@noxifoxi
Copy link

Why does it take so long for this to get merged? 🤨

@SoftCreatR
Copy link
Contributor Author

Well, that applies for most PRs. I have no idea, why it takes so long.

@KevinLaMS KevinLaMS added the Validation-Installation-Error Error installing application label May 30, 2020
@ghost
Copy link

ghost commented May 30, 2020

SoftCreatR The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels May 30, 2020
@KevinLaMS
Copy link
Contributor

I get Installer failed with exit code 1603

@ghost ghost removed the Needs: author feedback label May 30, 2020
@SoftCreatR
Copy link
Contributor Author

SoftCreatR commented May 30, 2020 •
edited
Loading

1603

From https://support.microsoft.com/en-us/help/834484/you-receive-an-error-1603-a-fatal-error-occurred-during-installation:

You may receive this error message if any one of the following conditions is true:

  • Windows Installer is attempting to install an app that is already installed on your PC.
  • The folder that you are trying to install the Windows Installer package to is encrypted.
  • The drive that contains the folder that you are trying to install the Windows Installer package to is accessed as a substitute drive.
  • The SYSTEM account does not have Full Control permissions on the folder that you are trying to install the Windows Installer package to. You notice the error message because the Windows Installer service uses the SYSTEM account to install software.

During my tests, it worked fine.

@SoftCreatR SoftCreatR dismissed stale reviews from noxifoxi and Reset816 via 8aaea6e May 30, 2020 15:24
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot removed the Validation-Installation-Error Error installing application label May 30, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 30, 2020
@ghost
Copy link

ghost commented May 30, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Completed Validation passed label Jun 3, 2020
@ghost
Copy link

ghost commented Jun 3, 2020

Hello @KevinLaMS!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost
ghost approved these changes Jun 3, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 815c9aa into microsoft:master Jun 3, 2020
@Kissaki Kissaki mentioned this pull request May 22, 2021
Merged
5 tasks
Kissaki added a commit to Kissaki/winget-pkgs that referenced this pull request May 22, 2021
@Kissaki
Prevent auto restart after LibreOffice install
7312e95 
Commit 815c9aa (PR microsoft#1210) fixed this for the 6.4 version manifest file.

This change adds the `/qn /norestart` to the 7.0 manifest files where it is missing, resulting in an unprompted PC restart on upgrade.

Fixes microsoft#1154
Kissaki added a commit to Kissaki/winget-pkgs that referenced this pull request May 22, 2021
@Kissaki
Prevent auto restart after LibreOffice install
6af135f 
Commit 815c9aa (PR microsoft#1210) fixed this for the 6.4 version manifest file.

This change adds the `/qn /norestart` to the 7.1 manifest files where it is missing, resulting in an unprompted PC restart on upgrade.

Fixes microsoft#1154
@Kissaki Kissaki mentioned this pull request May 22, 2021
Merged
5 tasks
ghost pushed a commit that referenced this pull request May 22, 2021
@Kissaki
Prevent auto restart after LibreOffice install (#13680)
92ca710 
Commit 815c9aa (PR #1210) fixed this for the 6.4 version manifest file.

This change adds the `/qn /norestart` to the 7.0 manifest files where it is missing, resulting in an unprompted PC restart on upgrade.

Fixes #1154
ghost pushed a commit that referenced this pull request May 22, 2021
@Kissaki
Prevent auto restart after LibreOffice install (#13775)
1a5c103 
Commit 815c9aa (PR #1210) fixed this for the 6.4 version manifest file.

This change adds the `/qn /norestart` to the 7.1 manifest files where it is missing, resulting in an unprompted PC restart on upgrade.

Fixes #1154
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reset816 Reset816 Reset816 left review comments

@noxifoxi noxifoxi noxifoxi left review comments

Assignees

@samiranshah-zz samiranshah-zz

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LibreOffice - Reboot after installation
6 participants
@SoftCreatR @wingetbot @Reset816 @noxifoxi @KevinLaMS @samiranshah-zz