Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Microsoft.WindowsTerminal version 1.18.2681.0 #120906

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Sep 26, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?
Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Dependencies Needs-Author-Feedback This needs a response from the author. labels Sep 26, 2023
@mdanish-kh
Copy link
Contributor

This is probably failing due to MinimumVersion not being enabled in the pipelines

@DHowett
Copy link
Member

DHowett commented Sep 26, 2023

Hey there! This looks like a duplicate of #120903

@DHowett
Copy link
Member

DHowett commented Sep 26, 2023

I think yours is better though...!

@Trenly
Copy link
Contributor Author

Trenly commented Sep 26, 2023

This is probably failing due to MinimumVersion not being enabled in the pipelines

Actually, I think the pipelines are still on WinGet 1.4

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 26, 2023
@Trenly
Copy link
Contributor Author

Trenly commented Sep 26, 2023

Hey there! This looks like a duplicate of #120903

That it is - but intentionally so; Since 1.6 was released, we are waiting for the 1.6 client to hit the pipelines and for dependencies validation to be enabled. Since Terminal is such a popular package, I would hope that someone like @stephengillie would be able to manually validate the package, although I know that can't be done for every single package that has dependencies.

Rather than try to take that PR and figure out if it is correct or needs modification or what the deal is, when working with new features it is easier to make a new PR that references and closes the old one. This way I know that the content should pass a manual validation but it still keeps the history of the previous PR

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 26, 2023
@denelon
Copy link
Contributor

denelon commented Sep 26, 2023

@Trenly if you can share your screenshot of this working with the dependencies, I'll merge it.

@Trenly
Copy link
Contributor Author

Trenly commented Sep 26, 2023

@Trenly if you can share your screenshot of this working with the dependencies, I'll merge it.

image

@denelon

@denelon denelon merged commit 194d09c into microsoft:master Sep 26, 2023
@Trenly Trenly deleted the Microsoft.WindowsTerminal-1.18.2681.0-542351707F8E3E branch September 26, 2023 21:49
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 26, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: Windows Terminal
7 participants