Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define manifest for .NET SDK #120

Merged
3 commits merged into from
May 14, 2020
Merged

Define manifest for .NET SDK #120

3 commits merged into from
May 14, 2020

Conversation

MichaelSimons
Copy link
Member

@MichaelSimons MichaelSimons commented May 14, 2020

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 14, 2020
@ghost
Copy link

ghost commented May 14, 2020

MichaelSimons The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the YAML file is compliant with the package manager specification (https://github.com/microsoft/winget-pkgs/YAMLSpec.md)
For details on the error, see the details link below in the build pipeline.

@MichaelSimons
Copy link
Member Author

One issue I have seen with this manifest is that you must install within an elevated shell. If you don't, there is an indefinite hang.

@ghost ghost removed the Needs: author feedback label May 14, 2020
@denelon
Copy link
Contributor

denelon commented May 14, 2020

@MichaelSimons the ManifestVersion will need to be commented out. We're leveraging a library from the client, and that attribute isn't fully supported yet. It should be commented out on the primary README.md file now.

@denelon denelon self-assigned this May 14, 2020
@wingetbot wingetbot removed the Manifest-Validation-Error Manifest validation failed label May 14, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 14, 2020
@ghost ghost assigned KevinLaMS May 14, 2020
@ghost
Copy link

ghost commented May 14, 2020

This submission has moved to manual review.

@denelon denelon added the Validation-Completed Validation passed label May 14, 2020
@ghost
Copy link

ghost commented May 14, 2020

Hello @denelon!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation has completed

@ghost ghost merged commit 970c14f into microsoft:master May 14, 2020
@MichaelSimons MichaelSimons deleted the initial-dotnet branch May 14, 2020 20:05
ghost pushed a commit that referenced this pull request May 15, 2020
* Adding PDFsam - PDF Split and Merge which is a free and open-source cross-platform desktop application to split, merge, extract pages, rotate and mix PDF documents.

* VNC Viewer - Virtual network computing (VNC) is a type of remote-control software that makes it possible to control another computer over a network connection.

* Winrartypo (#97)

* wireshark

* fixed incorrect name

* added missing wire

* added missing wire

* added missing wire

* Create 2.19.791.0.yaml (#99)

* Create 1.0.0.yaml (#96)

* Create 4.5.11.yaml - Adobe Digital Editions (#102)

* Create 4.5.11.yaml

* Update 4.5.11.yaml

* Update and rename manifests/Adobe/Adobe Digital Editions/4.5.11.yaml to manifests/Adobe/AdobeDigitalEditions/4.5.11.yaml

* Update 4.5.11.yaml (#104)

* Update README.md (#105)

* Update README.md

* Update README.md

Co-authored-by: Kevin Larkin (MS) <[email protected]>

* Team2 (#98)

* wireshark

* Add Teams

* missing wireshark

* missing wireshark

* ConfigMgr Toolkit 5.00.7958.1151.yaml (#73)

* Create 5.00.7958.1151.yaml

* Update 5.00.7958.1151.yaml

* Added 18362 SDK (#108)

* add the mouse (#110)

* Whatsapp (#111)

* Reader\2020.009.20063.yaml

* reader fixed bad yaml

* whats app

* removed error

* Added build 19041 of Windows SDK (#109)

* Add 17763 SDK (#107)

* bumping to Windows Terminal 0.11.1333.0 (#117)

* Define manifest for .NET SDK (#120)

* Define manifest for .NET SDK 3.1.202

* Remove invalid log property

* Remove comment out unupported ManifestVersion property

* adding bitwarden desktop 1.17.2 (#119)

* adding bitwarden desktop 1.17.2

* remove ManifestVersion to resolve pipeline validation issue

* Opera (#115)

* Add chrome

* typo in version

* Opera

* removed

* Chrome (#114)

* Add chrome

* typo in version

* removed file

* Adding Cura 4.5.0 (#129)

* Added .gitattributes

.yaml files are text

* Adding EdgeSetup

* Moved into EdgeSetup Folder

* Rename EdgeSetup.yaml to 1.3.127.1.yaml

* Removing manifest from PR

* Adding Cura 4.5.0

* Delete .gitattributes

* Delete 1.3.127.1.yaml

* Modifying slient with progress switch to show UI with no interaction

* Adding license which is a required field

Co-authored-by: Kevin Larkin (MS) <[email protected]>
Co-authored-by: dianmsft <[email protected]>
Co-authored-by: John Vintzel <[email protected]>
Co-authored-by: denelon <[email protected]>
Co-authored-by: RDMacLachlan <[email protected]>
Co-authored-by: Sean O'Brien <[email protected]>
Co-authored-by: Michael Simons <[email protected]>
Co-authored-by: Sean O'Brien <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants