7Zip 16.0.4.yaml #12

samiranshah-zz · 2020-05-04T00:25:31Z

Microsoft Reviewers: Open in CodeFlow

wingetbot · 2020-05-04T00:25:33Z

/AzurePipelines run

azure-pipelines · 2020-05-04T00:25:41Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-05-04T00:27:51Z

samiranshah The package manager bot determined that the metadata was not compliant. Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure your request is YAML syntax is correct. Please also verify the YAML file is compliant with the package manager specification (https://github.com/microsoft/appinstaller-pkgs/YAMLSpec.md)
For details on the error, see the error listed in the build pipeline.

wingetbot · 2020-05-04T00:29:38Z

/AzurePipelines run

azure-pipelines · 2020-05-04T00:29:46Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-05-04T00:36:15Z

This submission has moved to manual review.

ghost · 2020-05-04T17:04:23Z

samiranshah An issue was identified during the manual review, and the PR request cannot be approved. If you disagree with this resolution, please raise an issue and flag this PR for further discussion.

wingetbot · 2020-05-04T17:56:08Z

/AzurePipelines run

azure-pipelines · 2020-05-04T17:56:17Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-05-04T17:59:54Z

This submission has moved to manual review.

wingetbot · 2020-05-04T18:01:33Z

/AzurePipelines run

azure-pipelines · 2020-05-04T18:01:41Z

Azure Pipelines successfully started running 1 pipeline(s).

ghost · 2020-05-04T18:04:33Z

This submission has moved to manual review.

ghost · 2020-05-04T19:31:55Z

Hello @KevinLaMS!

Because this pull request has the Validation Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

ghost

Validation has completed

* Install powershell-yaml * Enforce ordering of keys * Create function for adding list parameters * Write Version Manifest using Yaml Parser * Add To-Do Section * Rebase on master and cleanup commit history * Revert inadvertent changes from testing * Implement logic for installers using YAML parser * Fix statement in incorrect position * Remove RAW writing * Begin reading MultiManifests using Yaml parser * Cleanup unneeded variables * Bump Version * Read parameters from singletons * Add Product Code * Abstract ReadInstallerManifest to sub-function * Fix: Handle uninitialized variables * Merge New/Update, add EditMetadata * Fix: Change EditMetadata to work on singleton manifests * Fix: Update Git commit messages for accuracy * Remove Empty Manifest Folders * Fix: Correct text * Fix: Remove code for testing * Feature: If old manifests exist, update in place to preserve extra keys * Fix: Null Error when creating new * Fix: Cast only when installer code * Fix: Respect installer locale * Fix: Use UTF8 Encoding * Sort Yaml Keys * Git error handling * Fixed Moniker prompt for NewLocale * minItems, maxItems, pattern, variable fix * Implemented minItems from Schema * Implemented maxItems from Schema * Implemented pattern from Schema * Implemented available Architecture's from Schema * Implemented available InstallerType's from Schema * Added $script: to some variables which needs to stay throughout the script Only tested with one manifest as of now Cleanup If/Else logic & Rebase on master * Update method of getting Product Code from installer * SignatureSha256 and PackageFamilyName (#5) * More CommitTypes * Fill in PR Parameters #21940 (#4) * Detect PackageFamilyName for MSIX/APPX (#8) * Update YamlCreate.ps1 * Update YamlCreate.ps1 * Exclude .validation (#9) * Exclude .validation * Added exclude to ExistingVersions Co-authored-by: Levvie - she/her <[email protected]> * Add new line for PackageFamilyName (#10) * Standardize Keypress Menus (#11) * Standardize Keypress Menus * Fix: Use variable instead of pipeline * Fix Help Texts & Spacing * Cleanup Git Messages * Filter by Yaml * Remove debugging line Co-authored-by: Esco <[email protected]> Co-authored-by: Kaleb Luedtke <[email protected]> Co-authored-by: Esco <[email protected]> * Replaced PrBodyContentReply `n with array (#12) * Menu reduction (#13) * Simplify Code + Make Issues Entry Safer * Check issue validity * Fix unintended Revert Co-authored-by: Esco <[email protected]> * Fix unintended Revert Co-authored-by: Esco <[email protected]> * Fix unintended Revert Co-authored-by: Esco <[email protected]> Co-authored-by: Esco <[email protected]> * More patterns (#15) Added pattern for * PackageIdentifier * PackageVersion * PackageFamilyName * PackageLocale * Readability (#16) * Add Comparison Functions for Readability * Simplify Validation Function * Fix: Missing text * Remove spaces from split function * Fix: Resolve renamed variable * Validate Installer Modes * Validate File Extensions with Pattern and Length * Add Custom Error Class (#18) * Create function for adding list parameters * Remove RAW writing * Remove Empty Manifest Folders * minItems, maxItems, pattern, variable fix * Implemented minItems from Schema * Implemented maxItems from Schema * Implemented pattern from Schema * Implemented available Architecture's from Schema * Implemented available InstallerType's from Schema * Added $script: to some variables which needs to stay throughout the script * Add Custom Error Class * Cleanup Class Constructor * Additional error messages + cleanup * Continue adding error messages * Switched Local formatter to OTBS + Static Strings (Where applicable) * Fix Spacing * Remove unused variables from rebase Co-authored-by: Esco <[email protected]> * Fix: Check for package before do-until * Finish Locale Errors * Fix Spacing Issues * Make Enums Case Sensitive * Fix Unique Items + Incorrect Variables Co-authored-by: Esco <[email protected]> * Subfolder fix (#21) * Fix: Subfolder Exists Erroring * Return * Write Unused Keys as Comments (#22) * Write Unused Keys as Comments * Exclude certain keys from appearing as comments * Comment only Locale + Version * Quick Update, Function Reduction, Detect Installer Types, Detect Installer Architectures, and Comments (#27) * Update YamlCreate.ps1 * auto-detect installer architecture * Fix Trenly#27 (comment) * Fix auto-detection * Apply suggestions from code review Co-authored-by: Kaleb Luedtke <[email protected]> * Move Test + Submit to main * Update Tools/YamlCreate.ps1 * fix quick-update check * Reduce input required for quick version update (#4) * Reduce input required for quick version update * Fix Product Code * Don't add null product code if no product code key exists * improve quick update * Move prompt outside of Read-Info for clarity * Move Update Prompt outside of Read-Info for clarity * Update Messages * if there are any errors due to this commit, i will revert changes * Add Comments for code clarity Co-authored-by: Kaleb Luedtke <[email protected]> * Fix error from when functions were moved * Handle Manifest Level Parameters (#34) * Begin Handling Manifest Level Parameters * Fix InstallModes * Add delete manifest functionality (#39) * Add functionality to manually delete manifests * Add settings file and script documentation (#38) * Do not default installer locale * Add a script settings file with documentation * Add setting to suppress quick update warning * Remove accidental file inclusion * Fix: Update SignatureSha256 in quick update mode (#41) * Change Settings to allow for negative suppression (#46) * Change Settings to allow for negative suppression * Fix sample settings file * Invalid SandboxTest variable Co-authored-by: Vedant Mohan Goyal <[email protected]> Co-authored-by: Kaleb Luedtke <[email protected]> Co-authored-by: Esco <[email protected]> Co-authored-by: Vedant Mohan Goyal <[email protected]> * Cleaner references to linked issues (#49) * Command Line Arguments (#50) * Add switch for settings * Allow PackageIdentifier and PackageVersion to be passed as optional parameters * Add -help switch and documentation * Settings File Location * Fix spacing issue [Trenly#49] Trenly#51 Co-authored-by: Kaleb Luedtke <[email protected]> Co-authored-by: Vedant Mohan Goyal <[email protected]> * Fix Parameter Reading and Condensing(#54) * Fix: Allow InstallerSwitch keys to be split between installer level and manifest level on a per-key basis * Fix: Save parameters to variables before removing them from manifest level * Fix: Sandboxtest not working * Fix: Prompt for PFN if file does not exist (#55) * Auto Mode (#58) * Auto Mode * Fix for same version * Keep ProductCodes for .exe files * Keep ProductCodes for .exe files in Option-2 * Simplify function names, add debug info (#62) * Fix: Allow autoupdate to update old package versions (#66) * Make Simple Update automatically detect Sha256, SignatureSha256, and ProductCode without prompts (#61) * Make Simple Update automatically detect Sha256, SignatureSha256, and ProductCode without prompts * Add Parameter Mode (#64) * Add Parameter Mode * Update YamlCreate.ps1 * Update YamlCreate.md Co-authored-by: Vedant Mohan Goyal <[email protected]> * Use Unique Branch Names (#67) * Use Unique Branch Names * Process Branch Names Safely * Fix: Allow values other than en-US for default locale (#70) * Made it so git config was only modified for the local repo. (#72) * Only modify git config for local repo. * Fixed 2214. * Support for settings on Linux and macOS (#73) * Support for settings on Linux and macOS * Easton's suggestion * Update YamlCreate.md * Update Tools/YamlCreate.ps1 Co-authored-by: Kaleb Luedtke <[email protected]> * Update YamlCreate.ps1 Co-authored-by: Kaleb Luedtke <[email protected]> * Check for open PR's before submitting (#69) * Check for open PR's before submitting * Rebase on c82b39f * Use API instead of CLI * Exit when user-choice to terminate Co-authored-by: Vedant Mohan Goyal <[email protected]> Co-authored-by: Vedant Mohan Goyal <[email protected]> * Throw when script error (#74) * Fix: Add locale when converting from singleton (#75) * Fix: Branch names when deleting (#79) * Fix: Don't check for PRs on deletion (#80) * Update PR Content when removing a manifest (#82) * Update PR Content when removing a manifest * More realistic character count limits * Add is:pr to exclude issues from results (#88) * Ensure file names are valid before saving (#85) * Ensure file names are valid before saving * Fix: Catch when content disposition doesn't exist * Fix UserAgent not following redirects * Additional Web Request Parameters * Fix: Min descriptor length + Agent * Fix: Escape Regex in variables (#91) * Fix: Only add moniker to defaultLocale (#92) * Chore: Add references to YamlCreate documentation (#93) * Typo (#94) * Chore: Add note to enable settings Co-authored-by: denelon <[email protected]> * Chore: Remove To-do message * Update YamlCreate.ps1 * Move integer validation (#99) * Rename String.Validate -> Test-String (#101) * Suppress Write-Host warnings from ScriptAnalyzer * Fix missing constructor parameter * Rename Write-Locale-Manifests -> Write-LocaleManifest * Rename Write-Version-Manifest -> Write-VersionManifest * Rename Write-Installer-Manifest -> Write-InstallerManifest * Rename Read-WinGet-LocaleManifest -> Read-LocaleMetadata * Rename Read-WinGet-InstallerManifest -> Read-InstallerMetadata * Rename Read-Installer-Values-Minimal -> Read-QuickInstallerEntry * Rename Read-Installer-Values -> Read-InstallerEntry * Rename Enter-PR-Parameters -> Read-PRBody * Rename Write-Colors -> Write-MulticolorLine * Use Named Parameters for AddYamlParameter * Use Named Parameters for AddYamlListParameter * Use Named Parameters for PromptInstallerManifestValue * Support ShouldProcess for removing manifests * Move Downloading of installer to a separate function * More function name updates * Fix: Download Method (#107) * Check for version when setting proxy (#109) * Use defaultLocale due to microsoft/winget-cli#1646 resolving microsoft/winget-cli#1595 Co-authored-by: Esco <[email protected]> Co-authored-by: Vedant Mohan Goyal <[email protected]> Co-authored-by: Levvie - she/her <[email protected]> Co-authored-by: Kaleb Luedtke <[email protected]> Co-authored-by: Easton Pillay <[email protected]> Co-authored-by: denelon <[email protected]>

Create 16.0.4.yaml

56e33fd

wingetbot added the Manifest-Validation-Error Manifest validation failed label May 4, 2020

ghost added the Needs: author feedback label May 4, 2020

Move manifest to 7zip folder

582d08b

wingetbot removed Manifest-Validation-Error Manifest validation failed Needs: author feedback labels May 4, 2020

wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 4, 2020

ghost assigned denelon May 4, 2020

KevinLaMS added the Manual Validation Error label May 4, 2020

ghost assigned samiranshah-zz May 4, 2020

Update 16.0.4.yaml

00c2556

wingetbot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Manual Validation Error labels May 4, 2020

wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 4, 2020

Update 16.0.4.yaml

b084b9e

wingetbot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 4, 2020

wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 4, 2020

KevinLaMS added the Validation Completed label May 4, 2020

ghost approved these changes May 4, 2020

View reviewed changes

ghost merged commit c1c9743 into microsoft:master May 4, 2020

KevinLaMS added the Needs: Attention label Apr 4, 2021

OfficialEsco added a commit to OfficialEsco/winget-pkgs that referenced this pull request Aug 13, 2021

Replaced PrBodyContentReply `n with array (microsoft#12)

097e2c7

OfficialEsco added a commit to OfficialEsco/winget-pkgs that referenced this pull request Oct 18, 2021

Replaced PrBodyContentReply `n with array (microsoft#12)

92dc432

seejdev pushed a commit to seejdev/winget-pkgs that referenced this pull request Nov 4, 2021

Make inter-project references project relative (microsoft#12)

0c67fe8

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7Zip 16.0.4.yaml #12

7Zip 16.0.4.yaml #12

samiranshah-zz commented May 4, 2020 •

edited by ghost

Loading

wingetbot commented May 4, 2020

azure-pipelines bot commented May 4, 2020

ghost commented May 4, 2020

wingetbot commented May 4, 2020

azure-pipelines bot commented May 4, 2020

ghost commented May 4, 2020

ghost commented May 4, 2020

wingetbot commented May 4, 2020

azure-pipelines bot commented May 4, 2020

ghost commented May 4, 2020

wingetbot commented May 4, 2020

azure-pipelines bot commented May 4, 2020

ghost commented May 4, 2020

ghost commented May 4, 2020

ghost left a comment

7Zip 16.0.4.yaml #12

7Zip 16.0.4.yaml #12

Conversation

samiranshah-zz commented May 4, 2020 • edited by ghost Loading

Microsoft Reviewers: Open in CodeFlow

wingetbot commented May 4, 2020

azure-pipelines bot commented May 4, 2020

ghost commented May 4, 2020

wingetbot commented May 4, 2020

azure-pipelines bot commented May 4, 2020

ghost commented May 4, 2020

ghost commented May 4, 2020

wingetbot commented May 4, 2020

azure-pipelines bot commented May 4, 2020

ghost commented May 4, 2020

wingetbot commented May 4, 2020

azure-pipelines bot commented May 4, 2020

ghost commented May 4, 2020

ghost commented May 4, 2020

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost left a comment

Choose a reason for hiding this comment

samiranshah-zz commented May 4, 2020 •

edited by ghost

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.