Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ncspot version 0.13.4. #118734

Closed
wants to merge 1 commit into from
Closed

Conversation

donwlewis
Copy link
Contributor

@donwlewis donwlewis commented Sep 2, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Sep 2, 2023
@stephengillie
Copy link
Collaborator

Hi @donwlewis,

The package has a dependency on VCRedist:
image

@microsoft-github-policy-service
Copy link
Contributor

Hello @donwlewis,

This package appears to require dependencies in order to install successfully.

This PR is blocked until support for dependencies is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/dependencySupport

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Sep 5, 2023
@wingetbot wingetbot added the Validation-Merge-Conflict Package could not be tested due to merge conflict. label Oct 4, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Oct 4, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 4, 2023
@stephengillie
Copy link
Collaborator

While I can't find the PR where this manifest was originally submitted, it appears to be already in our repo. Closing due to merge conflicts.

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Needs-Author-Feedback This needs a response from the author. labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Dependencies Validation-Executable-Error Validation-Merge-Conflict Package could not be tested due to merge conflict.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants