Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing jq manifest according to 1.4.0 schema #116426

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Fixing jq manifest according to 1.4.0 schema #116426

merged 2 commits into from
Aug 11, 2023

Conversation

RockyMM
Copy link
Contributor

@RockyMM RockyMM commented Aug 11, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: codeflow:open?pullrequest=#116426

@RockyMM
Copy link
Contributor Author

RockyMM commented Aug 11, 2023

To be honest, when I tested this manifest I did get

Command line alias added: "jq"

However, when I typed jq nothing happened. Should I logout/login or refresh the shell somehow?

@Trenly
Copy link
Contributor

Trenly commented Aug 11, 2023

To be honest, when I tested this manifest I did get

Command line alias added: "jq"

However, when I typed jq nothing happened. Should I logout/login or refresh the shell somehow?

The symlink likely wasn’t added due to not being run in admin mode. See

Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn’t actually change anything, as the items being at the root level of the manifest functions the same as them being at the installer level

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Aug 11, 2023
@microsoft-github-policy-service
Copy link
Contributor

RockyMM,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Aug 11, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 2270ce9 into microsoft:master Aug 11, 2023
7 checks passed
@microsoft-github-policy-service
Copy link
Contributor

Hello RockyMM,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@RockyMM
Copy link
Contributor Author

RockyMM commented Aug 13, 2023

To be honest, when I tested this manifest I did get

Command line alias added: "jq"

However, when I typed jq nothing happened. Should I logout/login or refresh the shell somehow?

The symlink likely wasn’t added due to not being run in admin mode. See

Thanks for the tip. I will try it out. As for the content of my PR, at least now the content is according to schema. I know it's not much but it's honest work 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants