Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: TeamXonotic.Xonotic version 0.8.6 #113718

Closed
wants to merge 1 commit into from
Closed

New package: TeamXonotic.Xonotic version 0.8.6 #113718

wants to merge 1 commit into from

Conversation

AsciiWolf
Copy link
Contributor

@AsciiWolf AsciiWolf commented Jul 30, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Closes #95619.

There are sadly three problems with this manifest at the moment:

  1. The game was detected as a malware by WinGet for some reason during the local winget install. There definitely is not any malware present in the game archive and it most likely got detected as such because the game executables are not signed.
  2. There is no Start Menu item created during the installation. This sadly seems to be a WinGet limitation and is most likely not possible for portable applications at the moment: Add start menu entries for portable applications winget-cli#2299
  3. When trying to start the game using a "xonotic" command from a Terminal, the game returns an error. This is caused by the game executable working directory not being the actual game directory when launched from a Terminal and everything works fine when changing the directory to the actual game directory and running the executable from there. Is there any way to modify the working directory of the command or its launch parameters?
Microsoft Reviewers: codeflow:open?pullrequest=#113718

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AsciiWolf AsciiWolf mentioned this pull request Jul 30, 2023
5 tasks
@wingetbot wingetbot added the Validation-Installation-Error Error installing application label Jul 30, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @AsciiWolf,

The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

Template: msftbot/validationError/installation/general

@AsciiWolf
Copy link
Contributor Author

Hmm, I thought I already signed the CLA (in a different MS repository).

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jul 30, 2023
@AsciiWolf
Copy link
Contributor Author

@microsoft-github-policy-service agree

@AsciiWolf
Copy link
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 113718 in repo microsoft/winget-pkgs

@CoolPlayLin
Copy link
Contributor

CoolPlayLin commented Jul 31, 2023

@AsciiWolf
Could you check the NestedInstallerFiles is correct?

@AsciiWolf
Copy link
Contributor Author

@CoolPlayLin It should be correct except for the false malware scan result and for the incorrect executable working directory. I am not sure how to solve the working directory issue.

@Trenly
Copy link
Contributor

Trenly commented Jul 31, 2023

3. When trying to start the game using a "xonotic" command from a Terminal, the game returns an error. This is caused by the game executable working directory not being the actual game directory when launched from a Terminal and everything works fine when changing the directory to the actual game directory and running the executable from there. Is there any way to modify the working directory of the command or its launch parameters?

[Policy] Zip-Binary

@microsoft-github-policy-service microsoft-github-policy-service bot added the zip-binary Depends on library files that aren't available via symlink label Jul 31, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @AsciiWolf,

This package appears to depend on .dlls that aren't available via symlink.

This PR is blocked until support for zipped binaries is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/zipBinary

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 31, 2023
@stephengillie stephengillie removed the Needs-Author-Feedback This needs a response from the author. label Aug 1, 2023
@AsciiWolf AsciiWolf closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Validation-Installation-Error Error installing application zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: Xonotic
6 participants