Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendicated.Vencord version 1.2.9 #107243

Conversation

solomoncyj
Copy link
Contributor

@solomoncyj solomoncyj commented May 18, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service
Copy link
Contributor

Hello @solomoncyj,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to install during dynamic validation. This test is designed to ensure that the application installs on all environments without warnings. Please, verify that the application installs correctly on architectures specified in the manifest using winget cli.

Template: msftbot/validationError/installers/shellExecute

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 18, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service
Copy link
Contributor

Hello @solomoncyj,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to install during dynamic validation. This test is designed to ensure that the application installs on all environments without warnings. Please, verify that the application installs correctly on architectures specified in the manifest using winget cli.

Template: msftbot/validationError/installers/shellExecute

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 18, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label May 18, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service
Copy link
Contributor

Hello @solomoncyj,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to install during dynamic validation. This test is designed to ensure that the application installs on all environments without warnings. Please, verify that the application installs correctly on architectures specified in the manifest using winget cli.

Template: msftbot/validationError/installers/shellExecute

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 18, 2023
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2023-05-18 02:44:05.925 [CLI ] ShellExecute installer failed: 1
InstallationVerification-x64-Scope_Undefined-Locale_Undefined-ErrorScreenshot_20230518094405

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2023-08-30 06:45:00.118 [CLI ] ShellExecute installer failed: 1
image

@stephengillie
Copy link
Collaborator

stephengillie commented Sep 1, 2023

This installed normally in a Windows 10 VM. I think the error might be due to the dependency. This might need to wait for the 1.6 release.

@solomoncyj solomoncyj marked this pull request as ready for review September 2, 2023 23:55
@solomoncyj
Copy link
Contributor Author

Can someone pls waiver this? Thanks

@stephengillie stephengillie self-assigned this Sep 8, 2023
@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Shell-Execute

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Shell-Execute labels Sep 8, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed Possible-Duplicate labels Sep 8, 2023
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: 2a85002f05ebaa13b0d3f633abacec9e9270ea284b97db1f0af78e375eff0b75
    • manifests\v\Vendicated\Vencord\Canary\1.2.10
    • manifests\v\Vendicated\Vencord\PTB\1.2.10

@microsoft-github-policy-service
Copy link
Contributor

solomoncyj,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit b2c57b3 into microsoft:master Sep 11, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 11, 2023
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@solomoncyj solomoncyj deleted the autogenerated/Vendicated.Vencord/6efb2a69-295b-4091-9a21-2b6e2bf91479 branch December 13, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Shell-Execute
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants