-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scope and ElevationRequirement: Codeblocks.Codeblocks #103057
Add scope and ElevationRequirement: Codeblocks.Codeblocks #103057
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
stephengillie, The check-in policies require a moderator to approve PRs from the community. Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission. Template: msftbot/requiresApproval/moderator |
@@ -7,7 +7,9 @@ MinimumOSVersion: 10.0.0.0 | |||
InstallerType: nullsoft | |||
Installers: | |||
- Architecture: x64 | |||
Scope: machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scope: machine |
The installation is machine-wide as it installs to C:\Program Files
, but the installer writes its uninstall entries to HKEY_CURRENT_USER
which will make WinGet think it's a user scoped installation in the upgrade scenario and subsequent upgrades of this package will error out with No applicable upgrade found
if we add Scope: machine
in the manifest.
This is a similar scenario to #94840 and the proper way to resolve this would be to have the publishers fix the installer to write the uninstall entries in the correct place.
Hello @stephengillie, The package manager bot determined changes have been requested to your PR. Template: msftbot/changesRequested |
Hello @stephengillie, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. Template: msftbot/noRecentActivity |
Hello @stephengillie, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. Template: msftbot/noRecentActivity |
2 similar comments
Hello @stephengillie, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. Template: msftbot/noRecentActivity |
Hello @stephengillie, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. Template: msftbot/noRecentActivity |
Pull request was closed
cc @stephengillie Does this need to be re-opened? |
Probably not. This was part of a project to prevent UAC prompts from interfering with Dev Home, by adding the |
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow