Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scope and ElevationRequirement: Codeblocks.Codeblocks #103057

Conversation

stephengillie
Copy link
Collaborator

@stephengillie stephengillie commented Apr 21, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Apr 21, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) April 21, 2023 01:28
@microsoft-github-policy-service
Copy link
Contributor

stephengillie,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@@ -7,7 +7,9 @@ MinimumOSVersion: 10.0.0.0
InstallerType: nullsoft
Installers:
- Architecture: x64
Scope: machine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scope: machine

The installation is machine-wide as it installs to C:\Program Files, but the installer writes its uninstall entries to HKEY_CURRENT_USER which will make WinGet think it's a user scoped installation in the upgrade scenario and subsequent upgrades of this package will error out with No applicable upgrade found if we add Scope: machine in the manifest.

This is a similar scenario to #94840 and the proper way to resolve this would be to have the publishers fix the installer to write the uninstall entries in the correct place.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Apr 21, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @stephengillie,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@microsoft-github-policy-service
Copy link
Contributor

Hello @stephengillie,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Apr 28, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @stephengillie,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

2 similar comments
@microsoft-github-policy-service
Copy link
Contributor

Hello @stephengillie,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

@microsoft-github-policy-service
Copy link
Contributor

Hello @stephengillie,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

auto-merge was automatically disabled May 5, 2023 10:40

Pull request was closed

@mdanish-kh
Copy link
Contributor

cc @stephengillie Does this need to be re-opened?

@microsoft-github-policy-service microsoft-github-policy-service bot removed the No-Recent-Activity No activity has occurred on this work item for seven days. label May 5, 2023
@stephengillie
Copy link
Collaborator Author

cc @stephengillie Does this need to be re-opened?

Probably not. This was part of a project to prevent UAC prompts from interfering with Dev Home, by adding the elevatesSelf parameter, and specifying scope where necessary. Since scope is incompatible with this application currently, the need for this individual change seems to have disappeared.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 5, 2023
@stephengillie stephengillie deleted the Add_scope_and_ElevationRequirement_Codeblocks_Codeblocks branch May 5, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants