[Package Request]:

[fabcard]

Package Requested

• I would like someone else to build the manifest.
• I would like help so I can submit the manifest.
• I have performed a search and couldn't find this package.
• I have checked that the installer for this package is not a standalone or portable executable or a .zip file
• I think there is a new version available and I have provided the URL.

Please provide the following information

Publisher: TechPowerUp
Publisher Url: https://www.techpowerup.com
Package Name: NVCleanstall
Description: NVCleanstall lets you customize the NVIDIA GeForce Driver package by removing components that you don't need (or want). This not only keeps things tidy, but also lowers disk usage and memory footprint.
Package Version: 1.10.0
Installer URL: https://www.techpowerup.com/download/techpowerup-nvcleanstall/

Current Package Identifier (for new versions):

[OfficialEsco]

We need a static link to add this, and i don't know how TechPowerUp's website actually work, but we know the link you get when clicking on the server is a temporarily link.
Imma tag @W1zzardTPU to see if he can help since hes the GPU-Z creator.

What and who needs to make it so we can use https://us2-dl.techpowerup.com/NVCleanstall_1.10.0.exe ?

• Sub question: Is there a link like https://auto-dl.techpowerup.com/NVCleanstall_1.10.0.exe ?

Installer info for when we get what we need; use /install to trigger the inno installer, /install /silent worked in PowerShell, however this appears when winget installs it

[W1zzardTPU]

Include "/files/" in the URL, remove the hash and use winget's user-agent, i.e.:

curl --head --user-agent "winget/xx" https://us2-dl.techpowerup.com/files/NVCleanstall_1.10.0.exe

There's no "auto-dl" subdomain .. thoughts on what that should do? Redirect to closest server?

"/install" extracts the installer (from resource) to %TEMP%, and runs it, additional parameters should get passed to InnoSetup

[OfficialEsco]

Include "/files/" in the URL, remove the hash and use winget's user-agent, i.e.:

curl --head --user-agent "winget/xx" https://us2-dl.techpowerup.com/files/NVCleanstall_1.10.0.exe

I actually intended to have /files/ in the url, guess i removed it on accident 🤦‍♂️

Edit:
It was indeed a copy-pasta issue

Found NVCleanstall [TechPowerUp.NVCleanstall] Version 1.10.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://us2-dl.techpowerup.com/files/NVCleanstall_1.10.0.exe
  ██████████████████████████████  3.42 MB / 3.42 MB
Successfully verified installer hash
Starting package install...

There's no "auto-dl" subdomain .. thoughts on what that should do? Redirect to closest server?

Yep, AFAIK its not a big issue tho, download seems to be just as fast for me atleast

"/install" extracts the installer (from resource) to %TEMP%, and runs it, additional parameters should get passed to InnoSetup

Uhm, might be out of your knowledge, but do you know why the error in the screenshot appeared WHEN installed via WinGet? (unless it fixes itself with the new url)

[W1zzardTPU]

I like the idea of "auto-dl", will work on this in the coming weeks, a bit busy right now with Intel Alder Lake launch

It was indeed a copy-pasta issue
Does that fix the installer error message, too?

[OfficialEsco]

Does that fix the installer error message, too?

It did not :(
It also seems to "complete" the install when the /install command is run, so it says "Successfully installed" however it did not

[W1zzardTPU]

I think I know what it is.

NVCleanstall will extract the installer to %TEMP%, launch it
and exit itself (while the installer is still running). I suspect winget deletes the downloaded file at that point. But the original exe is what the installer needs to complete the installation

Edit: maybe to clarify, the "installer" exe doesn't contain any data, just the installer logic. The data is the NVCleanstall exe, which just gets copied to the target directory

[OfficialEsco]

Late reply but @W1zzardTPU do you have an idea for a workaround?
Or a standalone installer we can use for WinGet?
Would it be possible to add a /wait command when /install is executed?

[W1zzardTPU]

Would it be possible to add a /wait command when /install is executed?

Certainly, or is there any way to have winget look for another running process and wait for that?

[OfficialEsco]

@denelon

[denelon]

• Support installers that close the install process and launch a new process for install winget-cli#418

I think this issue is intended to address that scenario. At least I hope it would cover it. We currently don't watch the process tree, just the thread we executed. It sounds like this installer is doing similar to what squirrel installers do.

[W1zzardTPU]

* [Support installers that close the install process and launch a new process for install winget-cli#418](https://github.com/microsoft/winget-cli/issues/418)

I think this issue is intended to address that scenario. At least I hope it would cover it. We currently don't watch the process tree, just the thread we executed. It sounds like this installer is doing similar to what squirrel installers do.

What's your ETA to address this?

[denelon]

We don't have an ETA. We tend to prioritize "bugs", then "features" in most general cases. We have quite a backlog of bugs currently in progress. Likely more than we will complete by the 1.2 target release. We communicate the roadmap in terms of GitHub Milestones. Note, the date and scope are not commitments, but a best attempt. I'm in the process of culling what won't be completed in the client 1.2 milestone, and looking at 👍 to determine the relative priority based on community feedback. In some cases, we do prioritize other issues based on internal or partner needs above the community vote alone.

Most of what I shared in just to help with transparency. We have a large surface area to deliver against between the Client, the reference REST implementation, the services for validation and publishing the default "winget" and "msstore" sources, the PowerShell cmdlets and all our other compliance, security, privacy, and localization concerns.

[W1zzardTPU]

Please test if www.techpowerup.com/wizzard/NVCleanstall_1.10.3.exe installs correctly using winget

I changed the installer logic so that it will launch the installer and wait for it to complete before it exits

[OfficialEsco]

Please test if www.techpowerup.com/wizzard/NVCleanstall_1.10.3.exe installs correctly using winget

I changed the installer logic so that it will launch the installer and wait for it to complete before it exits

Yeeeap that worked flawlessly

[W1zzardTPU]

Awesome, will push out the new build this week,

[fabcard]

Hello. Looks like they update the NVCleanstall (v1.11.0) to work with winget.
"...To fix a compatibility issue with winget, NVCleanstall will now wait for the installer to complete before terminating..."
Thanks.