Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support localization for parser messages #457

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Oct 4, 2023

Reference implementation taken from the wiki:

To localize the keywords "Required,Default" and the error messages, add the the string expressions of the class SentenceBuilder to the resource files.

I modified the file to resolve any VS warnings


Microsoft Reviewers: Open in CodeFlow

@mdanish-kh mdanish-kh requested a review from a team as a code owner October 4, 2023 20:03
@mdanish-kh mdanish-kh requested review from yao-msft and ryfu-msft and removed request for a team October 4, 2023 20:03
@mdanish-kh
Copy link
Contributor Author

mdanish-kh commented Oct 12, 2023

@ryfu-msft Can we get a new release shipped out after this PR? #453 seems to be affecting a lot of CI runners in the wild. Fortunately, the change didn't break any functionality but just that the CI runners exit with an exception and non-zero error code making the action show as "failed".

@ryfu-msft
Copy link
Contributor

@ryfu-msft Can we get a new release shipped out after this PR? #453 seems to be affecting a lot of CI runners in the wild. Fortunately, the change didn't break any functionality but just that the CI runners exit with an exception and non-zero error code making the action show as "failed".

I will go ahead and cut a new release now before this PR gets checked in, since it will take some time for the strings to get localized. Thanks for calling that out 😄

Copy link
Contributor

@ryfu-msft ryfu-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple nits for cleanup

src/WingetCreateCLI/Properties/Resources.resx Outdated Show resolved Hide resolved
src/WingetCreateCLI/Properties/Resources.resx Outdated Show resolved Hide resolved
@mdanish-kh
Copy link
Contributor Author

just a couple nits for cleanup

I added the new lines that since I saw them being used in other comments. I went ahead and cleaned all of the other ones too

@mdanish-kh mdanish-kh requested a review from ryfu-msft October 13, 2023 20:02
@ryfu-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft ryfu-msft merged commit c9e4eec into microsoft:main Oct 16, 2023
4 checks passed
@mdanish-kh mdanish-kh deleted the localizeParserMessages branch October 16, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parts of command-line parser output are not localized
2 participants