Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create #163 - Dependencies.md #954

Merged
merged 4 commits into from
May 11, 2021
Merged

Create #163 - Dependencies.md #954

merged 4 commits into from
May 11, 2021

Conversation

denelon
Copy link
Contributor

@denelon denelon commented May 10, 2021


Microsoft Reviewers: Open in CodeFlow

@denelon denelon requested a review from a team as a code owner May 10, 2021 19:24
@github-actions
Copy link

Misspellings found, please review:

  • debian
  • dependies
  • dustojnikhummer
  • fedorapeople
  • gurantee
  • heuristicly
  • issuecomment
  • JDKs
  • jfearn
  • jpalardy
  • JREs
  • keepin
  • libsolv
  • netlify
  • semver
  • SUSE
To accept these changes, run the following commands from this repository on this branch
pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"bcp google INET Langs oss REINSTALLMODE sourc Standalone vamus Wunused "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"debian dependies dustojnikhummer fedorapeople gurantee heuristicly inet issuecomment JDKs jfearn jpalardy JREs keepin langs libsolv netlify semver SUSE "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

@jsoref
Copy link
Contributor

jsoref commented May 10, 2021

Fwiw, the latest version will do a better job of annotating misspellings (you'll get 10 instead of duplicates).

Copy link
Member

@JohnMcPMS JohnMcPMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a fine starting point, but probably needs more details added. One thing that would be good to add now though would be what we are not planning to do. For instance, there has been discussion around a produces/consumes model as well, where a package could state that it produces "JRE" and another that it consumes "JRE", but I don't think that we are planning on doing that here.

@denelon
Copy link
Contributor Author

denelon commented May 10, 2021

@jsoref some of the misspellings appear to be part of URLs. Is that expected?

@github-actions
Copy link

Misspellings found, please review:

  • debian
  • dustojnikhummer
  • fedorapeople
  • issuecomment
  • JDKs
  • jfearn
  • jpalardy
  • JREs
  • libsolv
  • netlify
  • semver
  • SUSE
To accept these changes, run the following commands from this repository on this branch
pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"bcp google INET Langs oss REINSTALLMODE sourc Standalone vamus Wunused "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"debian dustojnikhummer fedorapeople inet issuecomment JDKs jfearn jpalardy JREs langs libsolv netlify semver SUSE "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

@github-actions
Copy link

Misspellings found, please review:

  • dustojnikhummer
  • fedorapeople
  • issuecomment
  • jfearn
  • jpalardy
  • netlify
  • semver
To accept these changes, run the following commands from this repository on this branch
pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spelling/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"bcp Debian google INET Langs oss REINSTALLMODE sourc Standalone vamus Wunused "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spelling/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spelling";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"debian dustojnikhummer fedorapeople inet issuecomment jfearn jpalardy langs netlify semver "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

@jsoref
Copy link
Contributor

jsoref commented May 11, 2021

@denelon: people make typos in urls, yes :-).

Also, a word that appears in a url if it's real is likely to appear elsewhere.

@denelon denelon merged commit 444d230 into microsoft:master May 11, 2021
@denelon denelon linked an issue May 11, 2021 that may be closed by this pull request
@denelon denelon deleted the Dependencies branch September 17, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for package dependencies
3 participants