Force output paths to use u8string with filesystem::path #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
reviewed
Jan 9, 2021
| { | ||
| // Force use of the UTF-8 string from a file path. | ||
| // This should not be necessary when we move to C++20 and convert to using u8string. | ||
| friend AppInstaller::Logging::LoggingStream& operator<<(AppInstaller::Logging::LoggingStream& out, std::filesystem::path& path) |
There was a problem hiding this comment.
std::filesystem::path& path [](start = 107, length = 27)
Is this override with non const variant used?
There was a problem hiding this comment.
Yes; when doing overload resolution, only the exact match will be considered a better candidate than the template. So a non-const local will not match the const& function. Unfortunately I'm not aware of a better way to force the compiler to "do everything as you would have except in this one case". I suppose it might be possible to add some dummy parameters to the template to make it a worse candidate function.
msftrubengu
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When paths with non-ASCII characters are used, logging them is resulting in an exception due to not being able to convert them to ASCII (the default behavior when forced to convert to a narrow char).
Change
To better handle all situations of output of a path, both the logging and reporting infrastructure have been enlightened to force the use of
u8String()when they see one.Microsoft Reviewers: Open in CodeFlow