Add msstore productId to export manifest and to wingetutil interop manifest object #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryfu-msft
previously approved these changes
Nov 1, 2024
| @@ -1284,6 +1284,9 @@ Do you agree to the terms?</value> | |||
| <data name="InstallFlowReturnCodeSystemNotSupported" xml:space="preserve"> | |||
| <value>The current system configuration does not support the installation of this package.</value> | |||
| </data> | |||
| <data name="InstallFlowReturnCodeCustomError" xml:space="preserve"> | |||
| <value>Installation failed with installer custom error. Contact package support.</value> | |||
There was a problem hiding this comment.
nit:
Suggested change
| <value>Installation failed with installer custom error. Contact package support.</value> | |
| <value>Installation failed with a custom installer error. Contact package support.</value> | |
| @@ -2521,6 +2524,9 @@ Please specify one of them using the --source option to proceed.</value> | |||
| <data name="APPINSTALLER_CLI_ERROR_INSTALL_UPGRADE_NOT_SUPPORTED" xml:space="preserve"> | |||
| <value>The installer does not support upgrading an existing package.</value> | |||
| </data> | |||
| <data name="APPINSTALLER_CLI_ERROR_INSTALL_CUSTOM_ERROR" xml:space="preserve"> | |||
| <value>Installation failed with installer custom error.</value> | |||
There was a problem hiding this comment.
Suggested change
| <value>Installation failed with installer custom error.</value> | |
| <value>Installation failed with a custom installer error.</value> | |
src/AppInstallerSharedLib/Errors.cpp
Outdated
| @@ -244,6 +244,7 @@ namespace AppInstaller | |||
| WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_INSTALL_INVALID_PARAMETER, "Invalid parameter."), | |||
| WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_INSTALL_SYSTEM_NOT_SUPPORTED, "Package not supported by the system."), | |||
| WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_INSTALL_UPGRADE_NOT_SUPPORTED, "The installer does not support upgrading an existing package."), | |||
| WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_INSTALL_CUSTOM_ERROR, "Installation failed with installer custom error."), | |||
There was a problem hiding this comment.
Suggested change
| WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_INSTALL_CUSTOM_ERROR, "Installation failed with installer custom error."), | |
| WINGET_HRESULT_INFO(APPINSTALLER_CLI_ERROR_INSTALL_CUSTOM_ERROR, "Installation failed with a custom installer error."), | |
ryfu-msft
approved these changes
Nov 1, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was needed as part of the effort to make exported manifest (from winget download msstore apps) to be re-parsed and uploaded to winget rest source.
Updated the some of the manifest schemas to add "required" for some required fields previously missing.
Also, during my cross validation with the manifest schemas, I found ExpectedReturnCode::Custom was added in manifest but not actually updated in code. So I updated the ExpectedReturnCode map in code with this change too.