Change meaning of AddOrUpdate return bool #4885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msftrubengu
approved these changes
Oct 16, 2024
|
So picky this requestor |
J'accuse |
ryfu-msft
pushed a commit
that referenced
this pull request
Oct 21, 2024
## Issue The requestor of this new (1.10) API needs to know whether the operation was an add or an update. At the same time, the "was the index modified" return value from Update has always been true for any changes since the manifest hash was added. ## Change Return `true` when adding and `false` when updating.
ryfu-msft
pushed a commit
that referenced
this pull request
Oct 21, 2024
## Issue The requestor of this new (1.10) API needs to know whether the operation was an add or an update. At the same time, the "was the index modified" return value from Update has always been true for any changes since the manifest hash was added. ## Change Return `true` when adding and `false` when updating.
ryfu-msft
added a commit
that referenced
this pull request
Oct 22, 2024
This reverts commit 3be2ba0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The requestor of this new (1.10) API needs to know whether the operation was an add or an update. At the same time, the "was the index modified" return value from Update has always been true for any changes since the manifest hash was added.
Change
Return
truewhen adding andfalsewhen updating.Validation
Updated the unit tests to reflect this semantic shift.
Microsoft Reviewers: Open in CodeFlow