Make adding overlapping ARP range a hard error #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msftrubengu
approved these changes
Oct 11, 2024
ryfu-msft
pushed a commit
that referenced
this pull request
Oct 21, 2024
## Change Implements two independent but related changes: 1. Makes adding/updating an overlapping ARP range a hard error 2. Adds `AddOrUpdate` functionality to the index so that callers don't need to know if the manifest is already present ## Validation Added/updated unit tests for ARP overlap. Added unit and interop test for AddOrUpdate.
ryfu-msft
pushed a commit
that referenced
this pull request
Oct 21, 2024
## Change Implements two independent but related changes: 1. Makes adding/updating an overlapping ARP range a hard error 2. Adds `AddOrUpdate` functionality to the index so that callers don't need to know if the manifest is already present ## Validation Added/updated unit tests for ARP overlap. Added unit and interop test for AddOrUpdate.
ryfu-msft
added a commit
that referenced
this pull request
Oct 22, 2024
This reverts commit 2e4c276.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Implements two independent but related changes:
AddOrUpdatefunctionality to the index so that callers don't need to know if the manifest is already presentValidation
Added/updated unit tests for ARP overlap.
Added unit and interop test for AddOrUpdate.
Microsoft Reviewers: Open in CodeFlow