Allow for smaller configuration outputs #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
previously approved these changes
Aug 27, 2024
| @@ -1369,27 +1369,31 @@ namespace AppInstaller::CLI::Workflow | |||
| auto getDetailsOperation = configContext.Processor().GetSetDetailsAsync(configContext.Set(), ConfigurationUnitDetailFlags::ReadOnly); | |||
| auto unification = anon::CreateProgressCancellationUnification(std::move(progressScope), getDetailsOperation); | |||
|
|
|||
| bool suppressDetailsOutput = context.Args.Contains(Args::Type::ConfigurationAcceptWarning) && context.Args.Contains(Args::Type::ConfigurationSuppressPrologue); | |||
There was a problem hiding this comment.
Should we validate that supress-prologue is not used on its own?
There was a problem hiding this comment.
It only controls output, not the results. I don't see it as harmful to be passed when it wouldn't do anything.
| @@ -3109,4 +3109,7 @@ Please specify one of them using the --source option to proceed.</value> | |||
| <data name="StoreInstall_PackageNotAvailableForCurrentSystem" xml:space="preserve"> | |||
| <value>The package is not compatible with the current Windows version or platform.</value> | |||
| </data> | |||
| <data name="ConfigurationSuppressPrologueArgumentDescription" xml:space="preserve"> | |||
| <value>Suppress the configuration prologue when possible</value> | |||
There was a problem hiding this comment.
I don't think this will be clear to either users or translators. Do we say "prologue" anywhere else?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
florelis
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
To prevent anything from outputting to our console, call
FreeConsolein the configuration server.To allow for output of primarily results, when
--accept-configuration-agreementsis passed, one can now also pass--suppress-prologueto prevent the initial details from being presented. The only output (beyond the temporary progress spinner+text) will then be the disclaimer warning and the individual results.Validation
Confirmed that both changes work manually.
Microsoft Reviewers: Open in CodeFlow