Split testing into separate pipeline job #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
reviewed
Jul 25, 2024
florelis
reviewed
Jul 25, 2024
| - job: 'Test' | ||
| timeoutInMinutes: 120 | ||
| dependsOn: 'Build' | ||
| condition: succeeded('Build') |
There was a problem hiding this comment.
Is the condition needed if it already has dependsOn?
There was a problem hiding this comment.
I tried that, and it turns out, yes. The default of succeeded() will be false because of the skipped jobs we don't run for PRs.
Comment on lines
+290
to
+310
| # Run BimSkim for all the binaries | ||
| - task: BinSkim@4 | ||
| displayName: 'Run BinSkim ' | ||
| inputs: | ||
| arguments: 'analyze | ||
| "$(buildOutDir)\AppInstallerCLI\winget.exe" | ||
| "$(buildOutDir)\WinGetUtil\WinGetUtil.dll" | ||
| "$(buildOutDir)\WindowsPackageManager\WindowsPackageManager.dll" | ||
| "$(buildOutDir)\Microsoft.Management.Deployment.InProc\Microsoft.Management.Deployment.InProc.dll" | ||
| "$(Build.SourcesDirectory)\src\WinGetUtilInterop\bin\WinGetUtil*Interop.dll" | ||
| "$(buildOutDir)\UndockedRegFreeWinRT\winrtact.dll" | ||
| "$(buildOutDir)\Microsoft.WinGet.Client.Cmdlets\Microsoft.WinGet.Client*.dll" | ||
| "$(buildOutDir)\ConfigurationRemotingServer\ConfigurationRemoting*Server.dll" | ||
| "$(buildOutDir)\ConfigurationRemotingServer\ConfigurationRemoting*Server.exe" | ||
| "$(buildOutDir)\ConfigurationRemotingServer\Microsoft.Management.Configuration*.dll" | ||
| "$(buildOutDir)\Microsoft.Management.Configuration\Microsoft.Management.Configuration*.dll" | ||
| "$(buildOutDir)\Microsoft.Management.Configuration.OutOfProc\Microsoft.Management.Configuration*.dll" | ||
| --config default --recurse' | ||
|
|
||
| - task: securedevelopmentteam.vss-secure-development-tools.build-task-publishsecurityanalysislogs.PublishSecurityAnalysisLogs@3 | ||
| displayName: 'Publish Security Analysis Logs' |
There was a problem hiding this comment.
Do we still need these? I think the pipeline templates we are using for production builds may be enough
There was a problem hiding this comment.
🤷 Wasn't my goal to change that.
azure-pipelines.yml
Outdated
|
|
||
| variables: | ||
| buildOutDir: $(Pipeline.Workspace)\Build.$(artifactIdentifier) | ||
| artifactsDir: $(Build.ArtifactStagingDirectory)\$(buildPlatform) |
There was a problem hiding this comment.
Why is the build platform needed here?
There was a problem hiding this comment.
It was before we split the architectures into their own jobs (although it probably wasn't done this way). Now it isn't, but it also doesn't hurt things.
Co-authored-by: Flor Chacón <[email protected]>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
florelis
previously approved these changes
Aug 1, 2024
Co-authored-by: Flor Chacón <[email protected]>
florelis
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
The goal of this change is to separate the tests from the build. Then, in the event of a spurious test failure, one needs only re-run the failed job rather than the entire build.
Microsoft Reviewers: Open in CodeFlow