Cherry pick servicing fixes to 1.8 #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Change Replace the expired store certificate with the newly generated one.
Change: - Explicitly set COM access permissions for packaged com invocations. Leave access permissions as default and do not register COM objects for manual invocation so that only RPC channel can be used for manual activation. - Update LaunchAndActivationString to allow Self, System, Built-in Admin and AppContainer only, require at least MediumIL for non-AC. - Move Configuration to a separate COM server, use default permission. A separate pr will be sent to update AppInstaller manifest. Validation: Validated manually with Microsoft Store invocation, Powershell invocation (elevated and non elevated), test sample code and Devhome invocation (on package management and configuration). Also specifically validated Store invocation with Built-in Administrator sign-in (previously not working).
|
Forgot to change target branch? |
… NonStore ,code refactoring & E2E Test Coverage (microsoft#4534) **Repair Command updates:** - Code changes eliminate installer type mapping for MSI/WIX and MSIX NonStore, leveraging native platform support for repairs. - Refactored code for better readability and maintainability. **AppInstallerTestExeInstaller - Repair support** - Refactored AppInstallerTestExeInstaller to support repair operations. The code now accommodates Modify Repair, Uninstaller Repair, and Installer Repair. - Minor refactoring is also part of this update **E2E Test Coverage:** - Added E2E tests for winget, targeting installer types such as - MSI, - NonStore MSIX, - Burn, Nullsoft, Inno, and Exe. - These tests aim to ensure reliability across Modify Repair, Uninstaller Repair, and Installer Repair scenarios. **How Validated:** - Configured LocalhostWebServer for local execution. - Executed WingetRepair Tests via Visual Studio TestExplorer, confirming all tests passed on the local machine  <!-- To check a checkbox place an "x" between the brackets. e.g: [x] --> - [x] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs). - [ ] This pull request is related to an issue. ----- ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4534)
yao-msft
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks the following commits into the 1.8 release branch:
Once this is approved, I will not squash but instead just merge.