Fix mixed elevation integration issue by using MemoryStream #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryfu-msft
approved these changes
Apr 26, 2024
ryfu-msft
added a commit
to ryfu-msft/winget-cli
that referenced
this pull request
Apr 26, 2024
…t#4413) This work is done together with @ryfu-msft Tested and validated on both Ryan and my machine. The issue is when InMemoryRandomAccessStream is used in ConfigurationRemoteServer, marshalling will complain about setting rpc security status too late. We fixed it by not using winrt InMemoryRandomAccessStream. Instead, we'll use System.IO.MemoryStream. ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/4413) --------- Co-authored-by: --global <[email protected]>
ryfu-msft
added a commit
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is done together with @ryfu-msft
Tested and validated on both Ryan and my machine.
The issue is when InMemoryRandomAccessStream is used in ConfigurationRemoteServer, marshalling will complain about setting rpc security status too late. We fixed it by not using winrt InMemoryRandomAccessStream. Instead, we'll use System.IO.MemoryStream.
Microsoft Reviewers: Open in CodeFlow