Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AdditionalLibraryDirectories to UndockedRegFreeWinRT #4374

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

AmelBawa-msft
Copy link
Contributor

@AmelBawa-msft AmelBawa-msft commented Apr 12, 2024

  • UndockedRegFreeWinRT.vcxproj already had spectre-mitigation enabled, but its dependencies .lib were picked from the non-spectre directory which was causing a BinSkim warning
The following modules were compiled with a toolset that supports /Qspectre but the switch was not enabled on the command-line:
comsuppw.lib, msvcprt.lib, MSVCRT.lib, MSVCRT.lib, vcruntime.lib
  • Adding explicit reference to the spectre in AdditionalLibraryDirectories to ensure the spectre version of the static libraries are picked by the linker
VC_LibraryPath_VC_{platform}_OneCore_spectre = C:\Program Files\Microsoft Visual Studio\2022\...\VC\Tools\MSVC\...\lib\spectre\{platform}
VC_LibraryPath_VC_{platform}_Desktop_spectre = C:\Program Files\Microsoft Visual Studio\2022\...\VC\Tools\MSVC\...\lib\spectre\onecore\{platform}

Microsoft Reviewers: Open in CodeFlow

@AmelBawa-msft AmelBawa-msft requested a review from a team as a code owner April 12, 2024 23:08
@AmelBawa-msft AmelBawa-msft merged commit 91eda88 into master Apr 16, 2024
11 checks passed
@AmelBawa-msft AmelBawa-msft deleted the user/amelbawa/winrtact-spectre branch April 16, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants