Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fuzzer and integrate with OneFuzz #4135
Update fuzzer and integrate with OneFuzz #4135
Changes from 18 commits
9c69471
3e45601
9e64302
7451077
0d1fc12
5d7462c
6942ea4
27b5b4a
42aa65e
be16314
9a15cc9
9b13098
211c373
74f23ec
f4b70d5
77029d1
72bb9d4
dfbae56
e8d9f5e
21779af
3074342
b86456e
a9094b5
2268c15
e113201
fa16e9e
5aaafb9
2495c61
3aaa60b
4f56d25
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel strongly that this condition should be changed so that the
fuzzing
job only runs for the master branch. I don't think we should overload the onefuzz task by submitting artifacts for every PR build as the task doesn't immediately give us any information about fuzzing bugs. Those are autogenerated by the onefuzz service and sent as an ADO notification. It would be less noisy if it only ran for a master branch commit because that is actual code that is checked in and not being worked on.If there are no objections, I will change this after this PR is reviewed and approved so that we can see it run to completion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if "the task doesn't immediately give us any information about fuzzing bugs", then we should consider running it only on ci builds