-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add suggested dictionaries for spellchecking and remove unneeded words #3885
Conversation
This comment has been minimized.
This comment has been minimized.
@jsoref why is the result different here than in a run from my fork? |
@florelis changes to the workflow file aren't applied until they're merged. -- You'll see that when I make my PR, I include items that will be removed in a subsequent run. Also, I should really send a PR to upgrade this repository to .22. -- what I do is copy over https://github.com/check-spelling/spell-check-this/tree/main/.github and work with it until it yields good results. Note that I'd counsel against using the win32 dictionary, I've found it contains too many typoed words. -- So bad that I've stopped suggesting it in .22. |
This comment has been minimized.
This comment has been minimized.
Thanks @jsoref |
Follow up to #3885 Removing words that are in the new dictionaries from the allow list
Changes: * general spelling/grammar * refreshed baseline metadata (roughly [spell-check-this@edccef0](https://github.com/check-spelling/spell-check-this/tree/edccef0d97da7e227dbec1d2c1faac5fd085f313)) * upgraded to [check-spelling v0.0.22](https://github.com/check-spelling/check-spelling/releases/tag/v0.0.22) *⚠️ there's one pattern that triggers in v0.0.21 (as part of this PR) which will not trigger once this PR is merged ([🩹 Pattern suggestions shouldn't trip over active patterns](https://github.com/check-spelling/check-spelling/wiki/Feature:-Suggest-patterns#multiple-patterns-for-a-line)) * refreshed workflow * slightly refreshed dictionaries -- I'm removing `cspell:cpp/src/cpp.txt`, but you could use it or `cspell:cpp/dict/cpp.txt` -- I think I missed that #3885 was adding it -- cpp suffers from the same problem as win32 -- too many misspelled words) * dropping commenting on pushes (people should migrate to github step summaries)
Added some pre-existing dictionaries suggested by the spellchecking action (e.g. for
win32
) and removed some that didn't make much sense for us to have (why did we even havehtml
andaws
?). Also removed the words that we don't need to have in ourexcludes.txt
orallow.txt
because they are already in one of the dictionaries (either existing or added).Microsoft Reviewers: Open in CodeFlow