Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suggested dictionaries for spellchecking and remove unneeded words #3885

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

florelis
Copy link
Member

@florelis florelis commented Nov 13, 2023

Added some pre-existing dictionaries suggested by the spellchecking action (e.g. for win32) and removed some that didn't make much sense for us to have (why did we even have html and aws?). Also removed the words that we don't need to have in our excludes.txt or allow.txt because they are already in one of the dictionaries (either existing or added).

Microsoft Reviewers: Open in CodeFlow

@florelis florelis requested a review from a team as a code owner November 13, 2023 23:58

This comment has been minimized.

@florelis
Copy link
Member Author

@jsoref why is the result different here than in a run from my fork?

@jsoref
Copy link
Contributor

jsoref commented Nov 14, 2023

@florelis changes to the workflow file aren't applied until they're merged. -- You'll see that when I make my PR, I include items that will be removed in a subsequent run.

Also, I should really send a PR to upgrade this repository to .22. -- what I do is copy over https://github.com/check-spelling/spell-check-this/tree/main/.github and work with it until it yields good results.

Note that I'd counsel against using the win32 dictionary, I've found it contains too many typoed words. -- So bad that I've stopped suggesting it in .22.

This comment has been minimized.

@florelis
Copy link
Member Author

Thanks @jsoref
I removed the win32 dictionary and added back all the items I had removed from it.
I put all of the items that aren't needed with the new dictionary at the end of allows.txt and will remove them in another PR

@florelis florelis merged commit 6bce9cd into microsoft:master Nov 14, 2023
5 checks passed
@florelis florelis deleted the spelling branch November 14, 2023 23:55
@jsoref jsoref mentioned this pull request Nov 15, 2023
2 tasks
florelis added a commit that referenced this pull request Nov 15, 2023
Follow up to #3885 
Removing words that are in the new dictionaries from the allow list
JohnMcPMS pushed a commit that referenced this pull request Jul 30, 2024
Changes:
* general spelling/grammar
* refreshed baseline metadata (roughly
[spell-check-this@edccef0](https://github.com/check-spelling/spell-check-this/tree/edccef0d97da7e227dbec1d2c1faac5fd085f313))
* upgraded to [check-spelling
v0.0.22](https://github.com/check-spelling/check-spelling/releases/tag/v0.0.22)
* ⚠️ there's one pattern that triggers in v0.0.21 (as part of this PR)
which will not trigger once this PR is merged ([🩹 Pattern suggestions
shouldn't trip over active
patterns](https://github.com/check-spelling/check-spelling/wiki/Feature:-Suggest-patterns#multiple-patterns-for-a-line))
* refreshed workflow
* slightly refreshed dictionaries -- I'm removing
`cspell:cpp/src/cpp.txt`, but you could use it or
`cspell:cpp/dict/cpp.txt` -- I think I missed that #3885 was adding it
-- cpp suffers from the same problem as win32 -- too many misspelled
words)
* dropping commenting on pushes (people should migrate to github step
summaries)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants